-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(capabilities): implement a wrapper for capabilities #12208
base: main
Are you sure you want to change the base?
Conversation
e1c3b1f
to
47bb67c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use store instead of browser storage. The purpose of keeping the last previous fetched capabilities is to check in case the new fetch renders a different list (on the same page) -> store is enough for that.
Might not work well for some files (as we have components, which are using Vue, and files like service/webrtc
|
47bb67c
to
0bf4beb
Compare
0bf4beb
to
77bc7dd
Compare
77bc7dd
to
326799e
Compare
- check talk-hash when joining federated conversation - keep and retrieve capabilities from BrowserStorage - distinguish cases for local and remote capabilities - implement 'hasTalkFeature' and 'getTalkConfig' helpers - respect local-only features and configs Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…with conversation switch) Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…ion related) Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
326799e
to
30650ac
Compare
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
No visual changes
🚧 Tasks
As it's a request to server, it should be asyncronous. That means we must in some case to wait for remote capabilities or re-render application based on response (which is now isn't happen and requires a reload, if capability has changed
Reload as we do for dirty hash
hasFeature
to replace longgetCapabilities()?.spreed?.features?.includes('capability')
🏁 Checklist