Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MediaSettings): sync preferences with devices direct selection #12189

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Apr 23, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
before-sticky After-sticky

🚧 Tasks

  • Do not show "Apply Settings" on changes that touch devices only.
  • Update preferences needs to be called @update:deviceId event. This will cover both media settings and Talk settings devices changes.
  • To move "check if preferences update is called at least once" to showModal(), because user may open and close media settings without any pref update and without reload. It makes more sense to also force it next time they open it.
  • Split audio and video preferences update

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

…ces are not set yet.

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
…show apply settings button to devices change

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added 3. to review feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients feature: call 📹 Voice and video calls labels Apr 23, 2024
@DorraJaouad DorraJaouad added this to the 💙 Next Major (30) milestone Apr 23, 2024
@DorraJaouad DorraJaouad self-assigned this Apr 23, 2024
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Let's wait for Daniel's input

src/components/MediaSettings/MediaSettings.vue Outdated Show resolved Hide resolved
src/utils/webrtc/MediaDevicesManager.js Outdated Show resolved Hide resolved
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
… be passed.

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/12185/devices-saving branch 2 times, most recently from 001af34 to 70f2279 Compare April 24, 2024 17:47
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not fond of the decision to open it only the first time, but with my comments that should match the issue description

src/components/MediaSettings/MediaSettings.vue Outdated Show resolved Hide resolved
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review feature: call 📹 Voice and video calls feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients
Projects
Status: 🏗️ In progress
2 participants