-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MediaSettings): sync preferences with devices direct selection #12189
base: main
Are you sure you want to change the base?
Conversation
…ces are not set yet. Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
…show apply settings button to devices change Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
23e6361
to
7a4772c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Let's wait for Daniel's input
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
… be passed. Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
001af34
to
70f2279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not fond of the decision to open it only the first time, but with my comments that should match the issue description
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
70f2279
to
495218a
Compare
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
@update:deviceId
event. This will cover both media settings and Talk settings devices changes.showModal()
, because user may open and close media settings without any pref update and without reload. It makes more sense to also force it next time they open it.🏁 Checklist