Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(browserCheck): unify ua-parser usage through the utils #11970

Merged
merged 1 commit into from
May 29, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 28, 2024

☑️ Resolves

  • Perform browser checks via single utils module
  • Tested with Chrome and Firefox

🖌️ UI Checklist

Follow-ups

  • replace webrtc-adapter library with ua-parser if possible

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • ⛑️ Tests are included or not possible

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy marked this pull request as ready for review May 29, 2024 13:27
@Antreesy Antreesy requested a review from ShGKme May 29, 2024 13:28
@ShGKme
Copy link
Contributor

ShGKme commented May 29, 2024

  • replace webrtc-adapter library with ua-parser if possible

webrtc-adapter?

@Antreesy
Copy link
Contributor Author

webrtc-adapter?

I see it's only used in the app as adapter.browserDetails.browser === 'safari', so basically checking for the same thing. But something for a follow-up, of course

@ShGKme
Copy link
Contributor

ShGKme commented May 29, 2024

I mean, I don't see anything related to webrtc-adapter in this PR

@Antreesy Antreesy enabled auto-merge May 29, 2024 13:37
@Antreesy Antreesy merged commit 8fe1a6a into main May 29, 2024
46 checks passed
@Antreesy Antreesy deleted the chore/noid/browser-check branch May 29, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants