Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files-sidebar): reduce initial loading size of Files sidebar #11551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(files-sidebar): reduce initial loading size of Files sidebar #11551

wants to merge 1 commit into from
+142 −31

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 8, 2024 •
edited

☑️ Resolves

  • Changes:
    • Initial sidebar tab registration takes only a loading placeholder
    • When tab becomes active, component triggers async load of main content and replace placeholder
    • From that moment, all logic should remain the same, only main content will be used for tab mounting

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
481 kB initial + 1.5 MB (chat + call) 41 kB initial + 1.2 MB (chat + call)
image image

🚧 Tasks

  • Check properly

🏁 Checklist

@Antreesy Antreesy added 2. developing feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents performance 🚀 labels Feb 8, 2024
@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Feb 8, 2024
@Antreesy Antreesy self-assigned this Feb 8, 2024
nickvergessen
nickvergessen requested changes Feb 8, 2024
View reviewed changes
src/mainFilesSidebarLoader.js Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the perf/noid/reduce-initial-sidebar-bundle branch from 7aa4a1e to a7feca1 Compare February 9, 2024 13:33
@Antreesy Antreesy force-pushed the perf/noid/reduce-initial-sidebar-bundle branch from a7feca1 to b3f1f06 Compare February 12, 2024 15:49
@Antreesy Antreesy requested a review from danxuliu March 1, 2024 15:10
@Antreesy Antreesy force-pushed the perf/noid/reduce-initial-sidebar-bundle branch from b3f1f06 to 787d5b7 Compare May 29, 2024 13:03
@Antreesy
fix(sidebar): reduce initial loading size of Talk files sidebar
d2a8064 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the perf/noid/reduce-initial-sidebar-bundle branch from 787d5b7 to d2a8064 Compare May 29, 2024 13:12
@Antreesy Antreesy marked this pull request as ready for review May 29, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme left review comments

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@danxuliu danxuliu Awaiting requested review from danxuliu

Requested changes must be addressed to merge this pull request.

Assignees

@Antreesy Antreesy

Labels
2. developing feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents performance 🚀
Projects
None yet
Milestone
💙 Next Major (30)
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Antreesy @nickvergessen @ShGKme