feat(SetupChecks): Refactor DatabaseHasMissingIndices #45272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtrichards
requested review from
nickvergessen,
st3iny,
susnux,
juliushaertl,
kesselb and
come-nc
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
check-db-missing-indices
branch
from
80fde3d
to
229e544
Compare
kesselb
approved these changes
May 12, 2024
juliushaertl
approved these changes
May 13, 2024
come-nc
reviewed
May 13, 2024
Comment on lines
+98
to
+102
| $processed++; | ||
| $list .= "\n " . $this->l10n->t('"%s" in table "%s"', [$missingIndex['indexName'], $missingIndex['tableName']]); | ||
| if (count($missingIndices) > $processed) { | ||
| $list .= ", "; | ||
| } |
There was a problem hiding this comment.
Ideally list should be formatted in markdown for security_guard.
There was a problem hiding this comment.
I can stick a - in front of each item in a follow-up, but it'll look funny in the current Overview since they will get displayed literally. Is there a more correct approach?
There was a problem hiding this comment.
Is there a more correct approach?
I don’t think so. We were pondering cutting after a double line break on core UI to be able to have more info only appearing in cli&security_guard but did not went forward with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Missing optional index [...]in front of every listed missing indexocccommandBefore
After
TODO
Checklist