Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check #45262

Merged
merged 1 commit into from May 13, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented May 10, 2024

Summary

Check for CLI mode in the second part of this check rather than return a result we can't be 100% certain about when running the check at the command line.

TODO

Checklist

@joshtrichards
Copy link
Member Author

/backport to stable29

@susnux
Copy link
Contributor

susnux commented May 11, 2024

Hm, I am not fully convinced here, as this check means that the cli.overwrite.url is not secure which might also be a problem?

@joshtrichards
Copy link
Member Author

joshtrichards commented May 12, 2024

@susnux You're right; I was looking at this wrong. Still needed adjustment, but a little differently. Updated. Give it another look.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@come-nc come-nc merged commit c31d6b1 into master May 13, 2024
155 checks passed
@come-nc come-nc deleted the check-HttpsUrlGeneration branch May 13, 2024 10:06
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants