Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable for inputs border width #45247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented May 10, 2024

Border width variable for input elements such as text fields and selects

core/css/variables.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is it used?

@marcoambrosini
Copy link
Member Author

In the vue library, and potentially other places
nextcloud-libraries/nextcloud-vue#5563

@marcoambrosini
Copy link
Member Author

marcoambrosini commented May 14, 2024

  • Add variable for focused input too

EDIT: not doing this because we're using different strategies for this depending on the elements (Combination of outlines and box shadow)

Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
@susnux susnux enabled auto-merge May 16, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
Status: 📐 At design
Development

Successfully merging this pull request may close these issues.

None yet

7 participants