Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using composer plugin with composer 2.2 #30409

Merged
merged 2 commits into from Dec 31, 2021
Merged

Allow using composer plugin with composer 2.2 #30409

merged 2 commits into from Dec 31, 2021

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl mentioned this pull request Dec 27, 2021
Closed
@juliushaertl
Copy link
Member Author

CI failure should be fixed by the next composer release composer/composer#10387

@MichaIng
Copy link
Member

MichaIng commented Dec 30, 2021 •
edited

Ah this fixes #30399, right? Missed that a fix is up already 👍.

Composer v2.2.2 has been released.

@ChristophWurst
Copy link
Member

/rebase

@juliushaertl @ChristophWurst
Allow using composer plugin with composer 2.2
b6a2600 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@ChristophWurst ChristophWurst marked this pull request as ready for review December 30, 2021 11:36
@ChristophWurst
Copy link
Member

Error: Cannot find file composer-bin-proxy:/home/runner/work/server/server/vendor-bin/psalm/vendor/vimeo/psalm/psalm to include

@juliushaertl
Ignore composer/bin
aeab523 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Copy link
Member Author

Pushed a commit to ignore composers bin directory for now. Another related upstream issue vimeo/psalm#7226

@juliushaertl juliushaertl merged commit 2c50f85 into master Dec 31, 2021
@juliushaertl juliushaertl deleted the bugfix/composer-plugin branch December 31, 2021 08:21
This was referenced Dec 31, 2021
Closed
Closed
Closed
@MichaIng
Copy link
Member

MichaIng commented Jan 1, 2022

/backport to stable23

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 1, 2022
Merged
@MichaIng MichaIng mentioned this pull request Jan 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@MichaIng MichaIng MichaIng approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juliushaertl @MichaIng @ChristophWurst