Rename IQueryBuilder::executeUpdate to IQueryBuilder::executeStatement #26877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because executeUpdate wasn't a great name. And in DBAL they also use executeStatement more consistently now. Ref doctrine/dbal#4607 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
rullzer,
MorrisJobke,
blizzz,
julien-nc and
solracsf
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
|
This will also better align with |
blizzz
reviewed
May 5, 2021
blizzz
approved these changes
May 5, 2021
nickvergessen
added a commit
to nickv-nextcloud/lifeline
that referenced
this pull request
May 8, 2021
Signed-off-by: Joas Schilling <coding@schilljs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because executeUpdate wasn't a great name. And in DBAL they also use
executeStatement more consistently now.
Ref doctrine/dbal#4607
This is a follow-up to @rullzer's #23665.
To lower the breakage of apps that were adapted early I added a monkey patched compatibility with a method of the old name in the implementation.