New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to … #22199
Merged
MorrisJobke
merged 1 commit into
master
from
techdebt/noid/PHPUnit_Framework_MockObject_MockObject
Aug 12, 2020
Merged
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to … #22199
MorrisJobke
merged 1 commit into
master
from
techdebt/noid/PHPUnit_Framework_MockObject_MockObject
Aug 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
rullzer,
nickvergessen,
icewind1991,
kesselb and
skjnldsv
August 11, 2020 19:34
MorrisJobke
force-pushed
the
techdebt/noid/PHPUnit_Framework_MockObject_MockObject
branch
2 times, most recently
from
August 11, 2020 21:33
a433b46
to
049627f
Compare
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 31652: failuremariadb10.4-php7.3Show full log
mysql8.0-php7.2
acceptance-app-files
Show full log
|
skjnldsv
approved these changes
Aug 12, 2020
kesselb
approved these changes
Aug 12, 2020
…to \PHPUnit\Framework\MockObject\MockObject Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
techdebt/noid/PHPUnit_Framework_MockObject_MockObject
branch
from
August 12, 2020 11:55
049627f
to
234b510
Compare
MorrisJobke
deleted the
techdebt/noid/PHPUnit_Framework_MockObject_MockObject
branch
August 12, 2020 11:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…\PHPUnit\Framework\MockObject\MockObject
Was changed in PHPUnit 8, which we use right now: sebastianbergmann/phpunit-mock-objects#408
Only touches test files and there in most cases only the PHPDoc. It only removes some
use
statements of the old class.With this then the IDE highlighting works properly.