Merge pull request #26878 from nextcloud/bugfix/noid/dont-break-occ-w…

…hen-an-app-is-breaking-in-application-class Don't break OCC if an app is breaking in it's Application class
nextcloud · May 5, 2021 · 4d82a94 · 4d82a94
2 parents 20b3487 + 784b059
commit 4d82a94
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 14 deletions.
diff --git a/lib/private/AppFramework/Bootstrap/Coordinator.php b/lib/private/AppFramework/Bootstrap/Coordinator.php
@@ -113,21 +113,24 @@ private function registerApps(array $appIds): void {
 			 */
 			$appNameSpace = App::buildAppNamespace($appId);
 			$applicationClassName = $appNameSpace . '\\AppInfo\\Application';
-			if (class_exists($applicationClassName) && in_array(IBootstrap::class, class_implements($applicationClassName), true)) {
-				try {
-					/** @var IBootstrap|App $application */
-					$apps[$appId] = $application = $this->serverContainer->query($applicationClassName);
-				} catch (QueryException $e) {
-					// Weird, but ok
-					continue;
-				}
-				try {
+			try {
+				if (class_exists($applicationClassName) && in_array(IBootstrap::class, class_implements($applicationClassName), true)) {
+					try {
+						/** @var IBootstrap|App $application */
+						$apps[$appId] = $application = $this->serverContainer->query($applicationClassName);
+					} catch (QueryException $e) {
+						// Weird, but ok
+						continue;
+					}
+
 					$application->register($this->registrationContext->for($appId));
-				} catch (Throwable $e) {
-					$this->logger->emergency('Error during app service registration: ' . $e->getMessage(), [
-						'exception' => $e,
-					]);
 				}
+			} catch (Throwable $e) {
+				$this->logger->emergency('Error during app service registration: ' . $e->getMessage(), [
+					'exception' => $e,
+					'app' => $appId,
+				]);
+				continue;
 			}
 		}
 

diff --git a/lib/private/legacy/OC_App.php b/lib/private/legacy/OC_App.php
@@ -135,7 +135,14 @@ public static function loadApps(array $types = []): bool {
 		ob_start();
 		foreach ($apps as $app) {
 			if (!isset(self::$loadedApps[$app]) && ($types === [] || self::isType($app, $types))) {
-				self::loadApp($app);
+				try {
+					self::loadApp($app);
+				} catch (\Throwable $e) {
+					\OC::$server->get(LoggerInterface::class)->emergency('Error during app loading: ' . $e->getMessage(), [
+						'exception' => $e,
+						'app' => $app,
+					]);
+				}
 			}
 		}
 		ob_end_clean();