-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPDX header #3496
Add SPDX header #3496
Conversation
a586fbe
to
a5b4715
Compare
Since the questions came up on the use of a generic spdx header: In essence: many people when having been asked how to deal with adding such headers voted in favor of the generic solution and an authors-list file. So PRs aren't polluted with header changes and folks aren't sending PRs which just change dates on copyright headers because it is a new year. |
498d824
to
29cdc1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to interrupt
Ist it possible to keep the first Autor aka copyright holder and the initial publishing date?
@dartcafe can you clarify a bit more? To comment on your request:
|
My point was just to respect the historical usage of the copyright entry. For me personally it is not important. |
29cdc1b
to
c9f8ca9
Compare
@v1r0x Do you have any comment for this change? Otherwise I would ask @AndyScherzinger for merging this PR. |
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
c9f8ca9
to
97012ff
Compare
Rebased and updated the latest, newly added files on the main branch to also ship SPDX headers |
Before we rebase frequently and in preparations for the upcomming changes, I vote for merging this. |
Fine by me of course. The reason I rebased were conflicts with the main branch and newly added files on master that didn't have SPDX headers. So while the PR is CI-green, after merging it to the main branch, any other newly created PR would be red given the REUSE Github action that would than fail. |
I would also say "can be merged", worst case we revert things or create follow-up PRs |
Currently there are no relevant PRs targeting master. That's because "now" is a good time. |
Yes, again, fine to be merged from my pov - of course 👍 |
🤣 I assumed the author merges, not the reviewer. |
Ah, alright. I thought you would decide to merge at some point if @v1r0x wouldn't reply 😅 |
In any way, very happy to have it in 🎉 |
AUTHORS.md