Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPDX header #3496

Merged
merged 7 commits into from
May 29, 2024
Merged

Add SPDX header #3496

merged 7 commits into from
May 29, 2024

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented May 8, 2024

  • replacing former license headers with standardized and unified SPDX headers
  • adding a GH action to check any future PRs for compliance
  • unified header => move any author to the newly added AUTHORS.md
  • Add Badge to the readme reflecting the current compliance status of the main branch

@AndyScherzinger
Copy link
Member Author

@dartcafe as mentioned the last days on the chat, here is the PR moving things to standardized SPDX headers - looking forward to your feedback as well @v1r0x

@AndyScherzinger
Copy link
Member Author

Since the questions came up on the use of a generic spdx header:

In essence: many people when having been asked how to deal with adding such headers voted in favor of the generic solution and an authors-list file. So PRs aren't polluted with header changes and folks aren't sending PRs which just change dates on copyright headers because it is a new year.

Copy link
Collaborator

@dartcafe dartcafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me.

@dartcafe dartcafe self-requested a review May 13, 2024 05:24
Copy link
Collaborator

@dartcafe dartcafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to interrupt
Ist it possible to keep the first Autor aka copyright holder and the initial publishing date?

@AndyScherzinger
Copy link
Member Author

@dartcafe can you clarify a bit more?

To comment on your request:

  • all files should have a date and that date should always be the year of the initial commit of that file
  • the first author is not the copyright holder, all authors are, so while one could add the first committer with an explicit copyright line, all other contributors also have a copyright. The same way the initial author has -> to the lines of code they contributed to that specific file. Hence I would argue to not add the first committer explicitely

@dartcafe
Copy link
Collaborator

My point was just to respect the historical usage of the copyright entry. For me personally it is not important.
Thanks for the explanation.

dartcafe
dartcafe previously approved these changes May 15, 2024
@dartcafe
Copy link
Collaborator

@v1r0x Do you have any comment for this change? Otherwise I would ask @AndyScherzinger for merging this PR.

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
Copy link
Member Author

Rebased and updated the latest, newly added files on the main branch to also ship SPDX headers

@dartcafe
Copy link
Collaborator

Before we rebase frequently and in preparations for the upcomming changes, I vote for merging this.

@AndyScherzinger
Copy link
Member Author

Before we rebase frequently and in preparations for the upcomming changes, I vote for merging this.

Fine by me of course. The reason I rebased were conflicts with the main branch and newly added files on master that didn't have SPDX headers. So while the PR is CI-green, after merging it to the main branch, any other newly created PR would be red given the REUSE Github action that would than fail.

@AndyScherzinger
Copy link
Member Author

I would also say "can be merged", worst case we revert things or create follow-up PRs

@dartcafe
Copy link
Collaborator

dartcafe commented May 29, 2024

Currently there are no relevant PRs targeting master. That's because "now" is a good time.

@AndyScherzinger
Copy link
Member Author

Yes, again, fine to be merged from my pov - of course 👍

@dartcafe
Copy link
Collaborator

🤣 I assumed the author merges, not the reviewer.

@dartcafe dartcafe merged commit efdfabe into master May 29, 2024
16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the chore/noid/spdx branch May 29, 2024 13:10
@AndyScherzinger
Copy link
Member Author

Ah, alright. I thought you would decide to merge at some point if @v1r0x wouldn't reply 😅

@AndyScherzinger
Copy link
Member Author

In any way, very happy to have it in 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants