Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-6] Count user's votes by subquery #3480

Merged
merged 7 commits into from May 14, 2024
Merged

Conversation

come-nc
Copy link

@come-nc come-nc commented May 6, 2024

Backport of #3477

@come-nc come-nc self-assigned this May 6, 2024
@come-nc come-nc changed the title Backport/3477/stable 6 [stable-6] Count user's votes by subquery May 6, 2024
lib/Db/Poll.php Outdated Show resolved Hide resolved
lib/Db/Poll.php Show resolved Hide resolved
lib/Db/PollMapper.php Outdated Show resolved Hide resolved
lib/Db/PollMapper.php Show resolved Hide resolved
@dartcafe
Copy link
Collaborator

dartcafe commented May 7, 2024

@come-nc I plan a new beta-release for tomorrow, since we got a request for the release before the end of this week. We can wait with this PR after it to get no risky situation.

dartcafe and others added 7 commits May 13, 2024 14:44
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc marked this pull request as ready for review May 13, 2024 13:00
@come-nc
Copy link
Author

come-nc commented May 14, 2024

@dartcafe Ready for review, this helps a lot with performances in my testing.

Copy link
Collaborator

@dartcafe dartcafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test, but I already reviewed it a few days ago.

lib/Db/PollMapper.php Show resolved Hide resolved
lib/Db/Poll.php Outdated Show resolved Hide resolved
lib/Db/Poll.php Show resolved Hide resolved
lib/Db/PollMapper.php Outdated Show resolved Hide resolved
@dartcafe
Copy link
Collaborator

BTW: Would you mind to add the grouping statements to the mappers, since the postgre error occured again. #3394 (comment)
Also see this comment

@come-nc come-nc merged commit dd20c6b into stable-6 May 14, 2024
15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport/3477/stable-6 branch May 14, 2024 12:53
@come-nc
Copy link
Author

come-nc commented May 14, 2024

BTW: Would you mind to add the grouping statements to the mappers, since the postgre error occured again. #3394 (comment) Also see this comment

I will open a backport for #3394 for stable-6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants