Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rich content placeholder position #3832

Merged
merged 1 commit into from Feb 28, 2023
Merged

Fix rich content placeholder position #3832

merged 1 commit into from Feb 28, 2023

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Feb 28, 2023 •
edited

This fixes the position of the cursor in the NcRichContenteditable component after one types text and deletes it again. I also adjusted the padding a bit, to bring the text to the center. Closes #3828.

Before:
Before

After:
After

@raimund-schluessler
Fix rich content placeholder position
3fed387 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler linked an issue Feb 28, 2023 that may be closed by this pull request
NcRichContenteditable shows cursor at end of placeholder when not focused #3828
Closed
@raimund-schluessler raimund-schluessler marked this pull request as ready for review February 28, 2023 09:03
@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components labels Feb 28, 2023
@raimund-schluessler raimund-schluessler added this to the 7.8.0 milestone Feb 28, 2023
@raimund-schluessler raimund-schluessler merged commit e719139 into master Feb 28, 2023
@raimund-schluessler raimund-schluessler deleted the fix/3828/rich-content-placeholder branch February 28, 2023 10:16
jancborchardt
jancborchardt approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! That was indeed strange :D

@julien-nc julien-nc mentioned this pull request Feb 28, 2023
Merged
@SystemKeeper SystemKeeper mentioned this pull request Apr 19, 2023
Open
@szaimen
Copy link
Contributor

szaimen commented Apr 19, 2023

This reintroduced #3853

@ShGKme ShGKme mentioned this pull request May 27, 2023
Closed
2 tasks
@ShGKme ShGKme mentioned this pull request Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@artonge artonge artonge approved these changes

@nimishavijay nimishavijay nimishavijay approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@ShGKme ShGKme Awaiting requested review from ShGKme

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
7.8.0
Development

Successfully merging this pull request may close these issues.

NcRichContenteditable shows cursor at end of placeholder when not focused
5 participants
@raimund-schluessler @szaimen @jancborchardt @artonge @nimishavijay