Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment textarea placeholder stickiness fix #5227

Conversation

Jerome-Herbinet
Copy link
Member

Fixes comment textarea placeholder stickiness. Seen in Circles. I don't have other usage of this field in other apps. I think we should check if it doesn't create problems elsewhere.

Check the video to understand :

Capture.video.du.09-02-2024.09.57.10.webm

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet Jerome-Herbinet requested review from susnux and ShGKme and removed request for susnux February 9, 2024 09:13
@Jerome-Herbinet Jerome-Herbinet added bug Something isn't working design Design, UX, interface and interaction design feature: richtext Related to the richtext component labels Feb 9, 2024
@Jerome-Herbinet
Copy link
Member Author

I could not commit cypress snapshots ; do you know why ?

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably bring back a bug in Firefox. See: #3832

@ShGKme ShGKme added this to the 8.8.2 milestone Feb 29, 2024
@juliushaertl juliushaertl modified the milestones: 8.8.2, 8.9.1 Mar 6, 2024
@Pytal Pytal modified the milestones: 8.9.1, 8.9.2 Mar 6, 2024
@ShGKme ShGKme modified the milestones: 8.9.2, 8.10.0, 8.10.1 Mar 8, 2024
@ShGKme ShGKme modified the milestones: 8.10.1, 8.11.0, 8.11.1 Mar 15, 2024
@Antreesy Antreesy modified the milestones: 8.11.1, 8.11.2 Mar 21, 2024
@Antreesy Antreesy modified the milestones: 8.11.2, 8.11.3 Apr 11, 2024
@Jerome-Herbinet Jerome-Herbinet deleted the Jerome-Herbinet-comment-textarea-placeholder-stickiness-fix branch May 13, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design Design, UX, interface and interaction design feature: richtext Related to the richtext component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants