Use NcTextField for NcActionInput
#3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
2. developing
raimund-schluessler
force-pushed
the
fix/3743/action-input-textfield
branch
from
c99e870
to
8abdd54
Compare
raimund-schluessler
changed the title
NcSelect for NcActionInput type text
raimund-schluessler
changed the title
NcSelect for NcActionInput type textNcTextField for NcActionInput type text
raimund-schluessler
force-pushed
the
fix/3743/action-input-textfield
branch
5 times, most recently
from
4ccdae5
to
fc0aefa
Compare
raimund-schluessler
force-pushed
the
fix/3743/action-input-textfield
branch
2 times, most recently
from
a725143
to
ddcafdf
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/3743/action-input-textfield
branch
from
ddcafdf
to
5c8cf43
Compare
raimund-schluessler
added
3. to review
raimund-schluessler
requested review from
susnux,
skjnldsv,
jancborchardt,
nimishavijay,
nickvergessen and
GretaD
raimund-schluessler
requested review from
Pytal,
marcoambrosini and
JuliaKirschenheuter
raimund-schluessler
changed the title
NcTextField for NcActionInput type textNcTextField for NcActionInput
susnux
approved these changes
Feb 22, 2023
jancborchardt
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Could you especially have a look at the color picker please? Before we used an input field of type color which gave the native colorpicker, now we use the colorpicker from nextcloud/vue.
Main question here would be if it's still accessible. In other places we tend to go with native solutions since they often are the closest to being accessible. Is it possible to make the element look like it does in your proposal but still use the input type color?
Also cc @Pytal @JuliaKirschenheuter regarding accessibility.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
NcTextFieldandNcPasswordFieldto theNcActionInputcomponent to unify the appearance.I had to enhance the
NcInputFieldcomponent a bit, to allow typenumberand enable adding a class to its input field.@jancborchardt @nimishavijay Could you especially have a look at the color picker please? Before we used an input field of type color which gave the native colorpicker, now we use the colorpicker from nextcloud/vue.