Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcDatetimePickers do not match the consistent NcAction style #3809

Closed
susnux opened this issue Feb 22, 2023 · 2 comments · Fixed by #3813
Closed

NcDatetimePickers do not match the consistent NcAction style #3809

susnux opened this issue Feb 22, 2023 · 2 comments · Fixed by #3813
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design feature: actions Related to the actions components feature: datepicker Related to the date/time picker component

Comments

@susnux
Copy link
Contributor

susnux commented Feb 22, 2023

With #3784 (thanks to @raimund-schluessler ) almost all NcAction... have a consistent style , except the DatePicker.

image

  • The default NcDatetimePicker
    • does not use a material icon so the icon stands out from the other actions.
    • does not have the same border style
    • the right margin of the icon looks smaller than the others (but might be only because of the different icon style)
  • The native NcDatetimePicker
    • looks like there is too much margin on the right side of the icon (compared to the other icons, like for password input or the submit on text inputs) (not possible, see comments below)
@susnux susnux added 1. to develop Accepted and waiting to be taken care of feature: datepicker Related to the date/time picker component feature: actions Related to the actions components design Design, UX, interface and interaction design labels Feb 22, 2023
@raimund-schluessler
Copy link
Contributor

The icon for the native datepicker comes from the browser, and I couldn't figure out a way how to style it yet (or even just remove it to put a custom one).

@susnux
Copy link
Contributor Author

susnux commented Feb 23, 2023

The icon for the native datepicker comes from the browser, and I couldn't figure out a way how to style it yet (or even just remove it to put a custom one).

Indeed, seems like only webkit browsers allow styling the icon.

@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design feature: actions Related to the actions components feature: datepicker Related to the date/time picker component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants