Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListItem Design update #3055

Merged
merged 3 commits into from Aug 22, 2022
Merged

ListItem Design update #3055

merged 3 commits into from Aug 22, 2022

Conversation

marcoambrosini
Copy link
Contributor

@marcoambrosini marcoambrosini commented Aug 17, 2022

Screenshot 2022-08-17 at 16 20 39

Signed-off-by: Marco Ambrosini marcoambrosini@icloud.com

@marcoambrosini marcoambrosini added enhancement New feature or request 3. to review Waiting for reviews labels Aug 17, 2022
@marcoambrosini marcoambrosini self-assigned this Aug 17, 2022
@marcoambrosini marcoambrosini changed the title Bold first line ListItem Design update Aug 17, 2022
Copy link
Contributor

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seal

@jancborchardt
Copy link
Contributor

Looks very nice! :) 2 questions which are related to ListItem design update:

  • Could we shorten the default date format also in the docs so devs use that: Shorten the relative time of envelopes nextcloud/mail#6992 (otherwise the date overlaps too much of the title line)
  • Shouldn’t the date and unread bubble be hidden on hover, in favor of the 3-dot menu, just like in Talk? Seems a bit much otherwise

@marcoambrosini
Copy link
Contributor Author

Shouldn’t the date and unread bubble be hidden on hover, in favor of the 3-dot menu, just like in Talk? Seems a bit much otherwise

Yes, by default they are. That second example you see in the docs is a special functionality required by mail in which the visibility of the actions is "forced"

Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me then. :)

@juliushaertl
Copy link
Contributor

@marcoambrosini Mind to rebase and resolve the conflict? :)

Signed-off-by: Marco Ambrosini <marcoambrosini@icloud.com>
Signed-off-by: Marco Ambrosini <marcoambrosini@icloud.com>
Signed-off-by: Marco Ambrosini <marcoambrosini@icloud.com>
@marcoambrosini marcoambrosini merged commit 8df28c8 into master Aug 22, 2022
@marcoambrosini marcoambrosini deleted the feature/noid/bold-first-line branch August 22, 2022 08:15
@skjnldsv skjnldsv mentioned this pull request Aug 23, 2022
@jotoeri
Copy link
Contributor

jotoeri commented Aug 23, 2022

Uhh, just saw this effect. Unfortunately, one-line listItems are quite overloaded now. @jancborchardt @marcoambrosini Can we make this optional? So maybe getting the class back, but making the bold-prop default to true?

grafik

@marcoambrosini
Copy link
Contributor Author

marcoambrosini commented Aug 24, 2022

The border radius is looking pretty bad in mail's three liners too, so I'd just propose to revert and have them consistent

Screenshot 2022-08-24 at 08 43 42

@jancborchardt
Copy link
Contributor

@marcoambrosini fix for that at #3136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants