-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert listItem bold title #3110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has been a misunderstanding, I was talking about the border radius in that comment, not the bolding of the title, which looks very good both in mail and talk.
I suggest that to address the issue in collectives we have 2 separate props:
boldTitle
that defaults true
boldSubtitle
that defaults false
Sorry for the confusion
stale
421734a
to
83a5041
Compare
Oups, sorry. Didn't read again before changing. |
True indeed – maybe makes sense to only have "boldTitle" and "boldAll"? |
I could change that, yes, makes it however a breaking change then? |
83a5041
to
afe0e1f
Compare
/backport to stable6 |
Fine, but then let's bold everything when this is true :) |
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
afe0e1f
to
a459773
Compare
Yes, that's what it does. There also is an example in the docs, but seems like the docs are broken currently unfortunately. 😢 |
As of #3055 (comment), reverting the #3055.