Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert listItem bold title #3110

Closed
wants to merge 1 commit into from
Closed

Revert listItem bold title #3110

wants to merge 1 commit into from

Conversation

jotoeri
Copy link
Contributor

@jotoeri jotoeri commented Aug 26, 2022

As of #3055 (comment), reverting the #3055.

@jotoeri jotoeri added 3. to review Waiting for reviews regression Regression of a previous working feature labels Aug 26, 2022
@jotoeri jotoeri added this to the 6.0.0 milestone Aug 26, 2022
juliushaertl
juliushaertl previously approved these changes Aug 28, 2022
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There has been a misunderstanding, I was talking about the border radius in that comment, not the bolding of the title, which looks very good both in mail and talk.
I suggest that to address the issue in collectives we have 2 separate props:
boldTitle that defaults true
boldSubtitle that defaults false
Sorry for the confusion

@jotoeri jotoeri added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 30, 2022
@jotoeri jotoeri dismissed stale reviews from juliushaertl and raimund-schluessler August 30, 2022 19:21

stale

@jotoeri
Copy link
Contributor Author

jotoeri commented Aug 30, 2022

@jotoeri jotoeri added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 30, 2022
@jotoeri
Copy link
Contributor Author

jotoeri commented Aug 31, 2022

boldTitle that defaults true
boldSubtitle that defaults false

Oups, sorry. Didn't read again before changing.
Now its bold and boldTitle. I thought a bold Subtitle on its own is probably not very useful? Hope, that's also fine?

@jancborchardt
Copy link
Contributor

I thought a bold Subtitle on its own is probably not very useful?

True indeed – maybe makes sense to only have "boldTitle" and "boldAll"?

@jotoeri
Copy link
Contributor Author

jotoeri commented Aug 31, 2022

True indeed – maybe makes sense to only have "boldTitle" and "boldAll"?

I could change that, yes, makes it however a breaking change then?

@jotoeri
Copy link
Contributor Author

jotoeri commented Sep 1, 2022

/backport to stable6

@marcoambrosini
Copy link
Contributor

Now its bold and boldTitle. I thought a bold Subtitle on its own is probably not very useful? Hope, that's also fine?

Fine, but then let's bold everything when this is true :)

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Copy link
Contributor Author

jotoeri commented Sep 6, 2022

Fine, but then let's bold everything when this is true :)

Yes, that's what it does. There also is an example in the docs, but seems like the docs are broken currently unfortunately. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants