Release 14.1.4-rc1

[Grotax]

Changed

• Basic Media-RSS support (Basic Media-RSS support #599)
• Database index improvements (Index improvements #637)

Fixed

• Don't install symfony/console via composer (Don't install symfony/console via composer #636)
• Fix for for ONLY_FULL_GROUP_BY (see Fix ONLY_FULL_GROUP_BY #80 #406) (Issue Group By errors on Mysql/MariaDB 5.7 #80) (Different solution for ONLY_FULL_GROUP_BY (see #406) (Issue #80) #407)
• Catch invalid feeds (Check if $feed is null #646)

Signed-off-by: Benjamin Brahmer info@b-brahmer.de

[Grotax]

As this contains DB migrations I thought doing one rc without rolling out to everyone might not hurt :)

[codecov-io]

Codecov Report

Merging #649 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #649   +/-   ##
=========================================
  Coverage     72.13%   72.13%           
  Complexity      680      680           
=========================================
  Files            58       58           
  Lines          2415     2415           
=========================================
  Hits           1742     1742           
  Misses          673      673           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db141be...959fe3c. Read the comment docs.

[SMillerDev]

Could you add a composer and npm update?

[tobiasKaminsky]

There is a new feed-io: https://github.com/alexdebril/feed-io/releases/tag/v4.5.4, which then also fixes #640

[Grotax]

Yea will do that

[Grotax]

npm update was already included, no new updates
composer update added the new feed-io version

[Grotax]

Changelog and commit message adjusted

[Grotax]

I would appreciate some testing, in my test the DB migration took some time but still ok. Will test the release by personal use for some time.

[abrain]

I'll also give the RC a test, to see if #607 is still there. It is not yet mentioned in the changelog, but with the bump of feed-io to version 4.5.4 it should be fixed, right?

[SMillerDev]

Yes it should

[abrain]

What is the expected behaviour in terms of feeds, that have not been updated for a while?

As far as I understood #607, the feeds have been fetched, but under a wrong assumption of the date of last modification, resulting in new items being ignored. As a side effect, the modification date in the database got updated. So I would expect only new items since the update of the news app to show up, because of this logic:

news/lib/Fetcher/FeedFetcher.php

Lines 85 to 89 in e7fee91

	if (empty($lastModified) || !is_string($lastModified)) {
	$resource = $this->reader->read($url);
	} else {
	$resource = $this->reader->readSince($url, new DateTime($lastModified));
	}

Is this assumption correct? And if so, would it be a good idea to reset the modification date in the database during migration, so the older (missing) feed items get imported, too?