Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never user
replace
but from https://getcomposer.org/doc/04-schema.md#replace it sounds a bit dangerous. Like you're telling composer that this package replaces guzzle and symfony/console. And I assume your intention is that the app shall fine and use the ones from server, right? So this can work if the composer here assumes the same guzzle version as in Nextcloud, but might fail hard otherwise, right? Like here composer assumes guzzle x is available, but in reality version y is shipped.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the libs here can also work with httplug instead of guzzle directly, you may also try https://packagist.org/packages/christophwurst/nextcloud-http-client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Using replace is tricky. symfony/console is luckily only a false positive. feed-io does not depend on symfony/console (actually it does but only for some cli scripts not used by news). guzzlehttp/guzzle maintains a stable api for a while. It seems that all guzzle versions shipped from Nextcloud 16 to Nextcloud 19 do work with feed-io.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen issues with Guzzle in
twofactor_gateway
when we shipped our own version. It was caused by_idn_uri_convert
or similar. It was somewhat related to guzzle/guzzle#2600 (comment) but I do not remember the details.