Use NcRichText component from @nextcloud/vue
#8170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
force-pushed
the
enh/noid/use-pickermodal-from-ncvue
branch
from
3ab2a47
to
effa05b
Compare
|
Ready IMO. |
|
The Richtext change looks good, but the upgrade to nc/vue 7.8 have this problem
|
julien-nc
force-pushed
the
enh/noid/use-pickermodal-from-ncvue
branch
from
effa05b
to
1ea2777
Compare
|
@GretaD I can't reproduce. Tested on Firefox and Chromium. Any specific window size or element of context? Rebased on main |
GretaD
approved these changes
Mar 3, 2023
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
GretaD
force-pushed
the
enh/noid/use-pickermodal-from-ncvue
branch
from
1ea2777
to
88050da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Circular dependency is definitely going down with the next
@nextcloud/vuerelease which will includeNcRichTextand everything needed for the link picker and the reference widgets.refs nextcloud-libraries/nextcloud-vue#3841 nextcloud-libraries/nextcloud-vue#3812
I'll update
@nextcloud/vueand set this to "ready for review" once the new release is out.