autoconfig: Allow mixing _FILE variables #1996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not always need to configure variables as either a file or not for all variables. Instead, allow us to mix-match variable storage. This allows us to keep all non-critical variables in regular (env) variables, but keep the password in a (secret) file only location. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
oliv3r
force-pushed
the
dev/allow_file_mix_match
branch
from
b20c8d8
to
94bff07
Compare
|
Related: #1942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not always need to configure variables as either a file or not for all variables.
Instead, allow us to mix-match variable storage. This allows us to keep all non-critical variables in regular (env) variables, but keep the password in a (secret) file only location.
By offering this change, we make it easier for the end-user, that does not have to know that this was an either/or proposition.