Prefer compose config over building containers #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There doesn't seem to be a need to prefer building custom containers, just to add a config file, a need that is easily solved with compose configs. Configs are still managed through git, just no new container needs to be built, slightly simplifying things. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
The cron container requires the files created by the app container, to start its cron tasks. There is a potential race condition here, where cron starts to run before the app container is even up, before the app container has populated `/var/www/html`. This is undesired and easily solved by making sure cron depends on the app container. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
oliv3r
force-pushed
the
dev/use_compose_config
branch
from
67f44fe
to
62ef4e9
Compare
|
This was on purpose due #538 (comment) |
|
@J0WI fair nuff; but it's 5 years later ... having bad practices in examples cause of windows is a poor excuse :D A note should be enough maybe? |
J0WI
reviewed
Jun 1, 2023
| restart: always | ||
| ports: | ||
| - 80:80 | ||
| - 443:443 | ||
| labels: | ||
| com.github.jrcs.letsencrypt_nginx_proxy_companion.nginx_proxy: "true" | ||
| configs: | ||
| - source: proxy | ||
| target: /etc/nginx/conf.d/uploadsize.conf |
There was a problem hiding this comment.
So far, we always used volumes instead of configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be a need to prefer building custom containers,
just to add a config file, a need that is easily solved with compose
configs. Configs are still managed through git, just no new container
needs to be built, slightly simplifying things.
While here, fix a cron-race-condition with regards the app container.