Fix new address book submit button border color #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
changed the title
ChristophWurst
added
design
|
Thanks a lot for the contribution @aryatalathi! For design changes it's recommended to post a before and after screenshot that shows the UI before your change and after. Could you add this here as a comment? Thanks! |
|
Hey @aryatalathi, Could you please post a before and after screenshot to demo your changes? Cheers |
|
Hey @aryatalathi, Could you please post a before and after screenshot to demo your changes? Cheers |
ChristophWurst
requested changes
Apr 20, 2023
| @@ -170,7 +170,7 @@ export default { | |||
| .settings-new-addressbook >>> .icon-confirm { | |||
| min-height: 44px; | |||
| height: 44px; | |||
| border-color: var(--color-border-dark) !important; | |||
| border-color: black !important; | |||
There was a problem hiding this comment.
I'm convinced this should use a css var, not a hard-coded value. The black border will be problematic with a bright theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3067