Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any calendar the user has access to, to be selected for the 'conflict calendar' #5934

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjrobertson
Copy link
Contributor

This is an attempted fix for #3786

Any calendar should be selectable for the 'conflict calendars', even if the user doesn't have write access to it. (e.g. a company has a 'holidays' calendar that a user should be able to select for conflicts.

Copy link

github-actions bot commented May 4, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

…nflict' calendar

Signed-off-by: Patrick Robertson <robertson.patrick@gmail.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 23.50%. Comparing base (397c78e) to head (fc98cfd).
Report is 1 commits behind head on main.

Files Patch % Lines
src/store/calendars.js 0.00% 4 Missing ⚠️
src/components/AppointmentConfigModal.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5934      +/-   ##
============================================
- Coverage     23.51%   23.50%   -0.01%     
  Complexity      455      455              
============================================
  Files           246      246              
  Lines         11722    11726       +4     
  Branches       2156     2146      -10     
============================================
  Hits           2756     2756              
- Misses         8650     8655       +5     
+ Partials        316      315       -1     
Flag Coverage Δ
javascript 15.15% <0.00%> (-0.01%) ⬇️
php 58.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant