calendar/issue/4128 : Feature: added between calendars patterns on events

[arublov]

Work in Progress

Needs nextcloud-libraries/nextcloud-vue#5318

☑️ Resolves

• Fix #4128

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (00ba483) to head (bbfd6b4).
Report is 69 commits behind head on main.

Additional details and impacted files

@@              Coverage Diff              @@
##               main    #5912       +/-   ##
=============================================
+ Coverage     23.31%   59.44%   +36.12%     
  Complexity      442      442               
=============================================
  Files           247       41      -206     
  Lines         11444     2224     -9220     
  Branches       1923        0     -1923     
=============================================
- Hits           2668     1322     -1346     
+ Misses         8776      902     -7874     

Flag	Coverage Δ
javascript	?
php	59.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[miaulalala]

Getting some errors when opening the calendar app initally:

• undefined
  
  I assume the default calendar pattern is not initialized properly as this is repeated for each calendar I have
• Patterns are enabled by default, no pattern should be set initially.
• Pattern picker doesn't open when clicking on the icon in the settings.
• Pattern picker is hard to see in dark mode:
  
• Pattern not shown in icon for Calendar List:
  
• Some lint errors for the Vue component as well, you can run npm run lint --fix to automatically fix them.

I really like this btw, so thanks for taking the time to work on this!

[arublov]

Getting some errors when opening the calendar app initally:

• undefined
  

I assume the default calendar pattern is not initialized properly as this is repeated for each calendar I have

• Patterns are enabled by default, no pattern should be set initially.
• Pattern picker doesn't open when clicking on the icon in the settings.
• Pattern picker is hard to see in dark mode:
  

@miaulalala yeah, I'll take your comment, this task is still in the WIP, but thanks for the comment :)

[miaulalala]

Getting some errors when opening the calendar app initally:

• undefined
  

I assume the default calendar pattern is not initialized properly as this is repeated for each calendar I have

• Patterns are enabled by default, no pattern should be set initially.
• Pattern picker doesn't open when clicking on the icon in the settings.
• Pattern picker is hard to see in dark mode:
  

@miaulalala yeah, I'll take your comment, this task is still in the WIP, but thanks for the comment :)

Just realised the undefined errors might be because I didn't check out the associated vue component branch. I added the branch to the description 👩‍💻

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!