Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Edit email on a per-calendar basis #5884

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

OrfeasLitos
Copy link

This intends to partially address #2617.

The overall idea is that the calendarEmail string attribute will be added to each calendar, which will be modifiable, just like the calendar name currently is. When an invitation is prepared, this attribute will be checked. If it isn't empty, the set value will be used, otherwise the organizer's email will be used as the organizer name in the invitation.

I would also like to add the ability to disable sending invitations from Nextcloud and let my calendar client (e.g., Thunderbird) take care of it, using the invitation with the user-selected email as described above. I have not yet implemented this part at all.

Is this a valuable feature? Does this approach make sense? If so, could you please point me to the code that prepares the invitation? I guess it interacts with dav, but it's unclear to me how.

Thanks in advance for giving me the pointers I need to contribute!

Signed-off-by: Orfeas Stefanos Thyfronitis Litos <orfeas.litos@hotmail.com>
Signed-off-by: Orfeas Stefanos Thyfronitis Litos <orfeas.litos@hotmail.com>
Signed-off-by: Orfeas Stefanos Thyfronitis Litos <orfeas.litos@hotmail.com>
@miaulalala
Copy link
Contributor

miaulalala commented Mar 29, 2024

Hi,

thanks for opening a PR!

I don't think setting the email for the whole calendar will work. There is no single email property for an entire Calendar Collection, but there is the calendar-user-address-set property, which contains a set of emails for each calendar principal. I don't thin it will achieve what I think you want to achieve, though.

Have you looked into the RFCs for calendaring? If not, I'd recommend reading up on them so the whole principal / calendar / CalDAV thing makes sense. It's quite a ride but it will help understanding how it works. All of our supported RFCs are here: https://github.com/nextcloud/calendar/wiki/Developer-Resources/

If you have any questions we have a public Talk room you can join as well: https://cloud.nextcloud.com/call/5qb8fujz

What I would do to make it work is implement support for the EMAIL property defined by RFC 7986, so an ORGANIZER can decide which email will be used to contact the ORGANIZER - that should address some of the concerns mentioned in the issue. The only concern I have is that I don't know how good the interoperability is with other Calendar Clients, so this would have to be tested properly.

Cheers :)

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants