Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate/vuex to pinia #5705

Open
wants to merge 65 commits into
base: main
Choose a base branch
from
Open

Migrate/vuex to pinia #5705

wants to merge 65 commits into from

Conversation

GVodyanov
Copy link
Contributor

@GVodyanov GVodyanov commented Jan 21, 2024 •
edited

Close #5686 as part of nextcloud/groupware#64

Continuation of #5685

TODO:

  • Migrate setting store
  • Update settings store usage
  • Migrate principals store
  • Update principals store usage
  • Migrate importState store
  • Update importState store usage
  • Migrate importFiles store
  • Update importFiles store usage
  • Migrate fetchedTimeRanges store
  • Update fetchedTimeRanges store usage
  • Migrate davRestrictions store
  • Update davRestrictions store usage (not found..?)
  • Migrate contacts store
  • Update contacts store usage (not found..?)
  • Migrate calendars store
  • Update calendars store usage
  • Migrate calendarObjects store
  • Update calendarObjects store usage
  • Migrate calendarObjectsInstance store
  • Update calendarObjectsInstance store usage
  • Remove mapGetters, mapState, etc.
  • Remove direct $store references
  • Recreate unit tests for all the stores
  • Manual testing (in progress)

@GVodyanov
Migrate/merge actions and mutations, still to adjust
3208236 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Make actions rely on mutations directly
cde2156 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Add pinia to application
122509c 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Use store in components
b4b5c2d 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Improve usage in component semantics
b0b6725 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Migrate settings store, still with TODOs relying on other stores
6a7ae80 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Import new settings store in Settings.vue
22fed4b 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov GVodyanov self-assigned this Jan 21, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.63%. Comparing base (4a9f810) to head (4ef760c).
Report is 351 commits behind head on main.

❗ Current head 4ef760c differs from pull request most recent head fc48105

Please upload reports for the commit fc48105 to get more accurate results.

Additional details and impacted files 
@@              Coverage Diff              @@
##               main    #5705       +/-   ##
=============================================
+ Coverage     24.44%   61.63%   +37.19%     
  Complexity      418      418               
=============================================
  Files           243       39      -204     
  Lines         10863     2101     -8762     
  Branches       1782        0     -1782     
=============================================
- Hits           2655     1295     -1360     
+ Misses         8208      806     -7402
Flag Coverage Δ
javascript ?
php 61.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GVodyanov
Update settings store usage
8d3bf36 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Migrate principals store
5f010b6 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Update principals store usages
1bd9a82 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Migrate importState store and its usages
4cf14d7 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Migrate importFiles store and its usages
5181cce 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Migrate fetchTimeRanges store
20eeed1 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Update fetchTimeRanges store usages
8b2853e 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Migrate davRestrictions store (no usages..?)
3628368 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Migrate contacts store (no usages..?)
73caffa 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Migrate calendar (in progress)
a84e0d7 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
Progress on calendars store migration
d856096 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
fixup! Progress on calendars store migration
3ec265b 
Finish migration and start updating usages
@GVodyanov
fixup! Progress on calendars store migration
4f74d4d 
Migrate getters uses of calendars store
@GVodyanov
fixup! Progress on calendars store migration
264174b 
Migrate calendars store usages
@GVodyanov
Migrate calendarObjects store and its usages
4ef760c 
Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov
chore(calendarObjectsStore)!: Start migration to Pinia
0c27e6c 
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
@GVodyanov
fixup! chore(calendarObjectsStore)!: Start migration to Pinia
65d9da7
@GVodyanov
Revert "fixup! chore(calendarObjectsStore)!: Start migration to Pinia"
11b519b 
This reverts commit 65d9da7.
@GVodyanov
fixup! chore(calendarObjectsStore)!: Start migration to Pinia
777f61f
@GVodyanov GVodyanov marked this pull request as ready for review May 23, 2024 17:39
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 24, 2024
st3iny
st3iny requested changes May 24, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second batch. One more left.

src/mixins/EditorMixin.js Outdated Show resolved Hide resolved
src/mixins/EditorMixin.js Outdated Show resolved Hide resolved
st3iny
st3iny reviewed May 24, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third batch done. Now, only manual testing and rebasing is left to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@GVodyanov GVodyanov

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace global Vuex store with Pinia
3 participants
@GVodyanov @st3iny @ChristophWurst