Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset attendees participation on eventDrop #5532

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

onny
Copy link

@onny onny commented Oct 15, 2023

Following change resets participation state of all attendees (except organizer) on eventDrop to NEEDS-ACTION. Considering that eventDrop would be always a significant change. This will trigger resending of an invitation.

This is a workaround for sabre-dav doesn't respecting RFC 6638 3.2.8: sabre-io/dav#1282

Addresses: nextcloud/server#13862

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7d484a9) 22.28% compared to head (a568764) 24.83%.
Report is 28 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5532      +/-   ##
============================================
+ Coverage     22.28%   24.83%   +2.55%     
  Complexity      388      388              
============================================
  Files           240      240              
  Lines         11793    10573    -1220     
  Branches       2301     1710     -591     
============================================
- Hits           2628     2626       -2     
+ Misses         9165     7947    -1218     
Flag Coverage Δ
javascript 15.80% <20.00%> (+1.97%) ⬆️
php 63.27% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/fullcalendar/interaction/eventDrop.js 90.90% <20.00%> (-9.10%) ⬇️

... and 95 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews bug Feature: Scheduling Anything around scheduling meetings, free-busy, resources, attendees and so on labels Oct 16, 2023
@ChristophWurst
Copy link
Member

Fixes: nextcloud/server#13862

I'd argue that it doesn't fully but only for events modified through our client and when they are dragged and dropped. Changes through other channels will still have the bug.

👍 for the workaround though

@tcitworld
Copy link
Member

Let's not close the server issue, if we can't merge sabre-io/dav#1443 in sabre we can always patch it in 3rdparty.

@onny
Copy link
Author

onny commented Oct 18, 2023

I agree, it addresses the server bug but resolves it only for the web client. Could we use this workaround until a proper fix is implemented? I looked into the sabre-dav code and a proper fix is propably more complicated

@onny
Copy link
Author

onny commented Oct 27, 2023

@miaulalala Signed my commit, tests should now hopefully pass :)

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@miaulalala
Copy link
Contributor

Unfortunately tests are failing

Signed-off-by: Jonas Heinrich <heinrich@synyx.de>
@onny
Copy link
Author

onny commented Oct 27, 2023

thank you for noticing! fixed the tests :) should still work as intended

@st3iny st3iny merged commit 8f39923 into nextcloud:main Oct 30, 2023
40 of 41 checks passed
@st3iny st3iny added this to the v4.6.0 milestone Oct 30, 2023
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 30, 2023
@st3iny
Copy link
Member

st3iny commented Oct 30, 2023

/backport to stable4.5

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Oct 30, 2023
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request A backport was requested for this pull request bug Feature: Scheduling Anything around scheduling meetings, free-busy, resources, attendees and so on feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants