Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event attachments to readme feature list #5119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

strobeflash
Copy link

Add the attachment feature to the readme
#4251

Add the attachment feature to the readme 
nextcloud#4251

Signed-off-by: strobeflash <68517177+strobeflash@users.noreply.github.com>
@ChristophWurst ChristophWurst changed the title Update README.md Add event attachments to readme feature list Mar 30, 2023
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 @sazanof

@ChristophWurst ChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (53cf255) 22.53% compared to head (35af25e) 22.53%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5119   +/-   ##
=========================================
  Coverage     22.53%   22.53%           
  Complexity      353      353           
=========================================
  Files           233      233           
  Lines         11383    11383           
  Branches       2145     2145           
=========================================
  Hits           2565     2565           
  Misses         8818     8818           
Flag Coverage Δ
javascript 14.02% <ø> (ø)
php 65.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -19,6 +19,7 @@
* :speaker: **Talk rooms!** Create an associated Talk room when booking a meeting with just one click
* :calendar: **Appointment booking** Send people a link so they can book an appointment with you [using this app](https://apps.nextcloud.com/apps/appointments)
* :see_no_evil: **We’re not reinventing the wheel!** Based on the great [c-dav library](https://github.com/nextcloud/cdav-library), [ical.js](https://github.com/mozilla-comm/ical.js) and [fullcalendar](https://github.com/fullcalendar/fullcalendar) libraries.
* :paperclip: **Attachments!** Add, upload and view attachments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this would be better one point up? So above we are not reinwenting the wheel?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants