Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to select contact groups as attendees #4742

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tcitworld
Copy link
Member

Kooha-2022-11-17-17-46-51.webm

A significant limitation is that if a contact has multiple addresses, all of them will be added (as shown in the above video). Unfortunately once attendees are added, their email addresses are currently not shown, so you can't know which attendee item to remove.

I'm not sure what's the best way to proceed here and I'd like your opinion on that (as well as @nextcloud/designers ):

  • only add the first email
  • show the email in the attendee list (always or when a contact is added with several emails), so that the user can remove the unwanted emails
  • add a special handling modal form to decide which email to pick (please don't say that 😅 ) ?
  • change the way the multiselect works to select actual contacts, not contacts emails, and then pick the email used in the attendee list. This means we also need to allow contacts being added twice if the user wants to sent invites to both emails.

(Also the message « Group contains X contacts » kinda lies, it's about the attendees emails, not the attendees contacts.

Closes #167

@tcitworld tcitworld added the 3. to review Waiting for reviews label Nov 17, 2022
@tcitworld tcitworld added this to In progress in Thomas things to do via automation Nov 17, 2022
@tcitworld tcitworld self-assigned this Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 23.96%. Comparing base (6b4845a) to head (2f96d9e).
Report is 2 commits behind head on main.

Files Patch % Lines
.../components/Editor/Invitees/InviteesListSearch.vue 0.00% 17 Missing ⚠️
...rc/components/Editor/Invitees/InviteesListItem.vue 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4742      +/-   ##
============================================
+ Coverage     23.92%   23.96%   +0.03%     
- Complexity      455      460       +5     
============================================
  Files           247      247              
  Lines         11517    11557      +40     
  Branches       1934     1944      +10     
============================================
+ Hits           2756     2770      +14     
- Misses         8761     8787      +26     
Flag Coverage Δ
javascript 15.45% <0.00%> (-0.05%) ⬇️
php 58.69% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 17, 2022

  • show the email in the attendee list (always or when a contact is added with several emails), so that the user can remove the unwanted emails

This was also discussed in #3853 (comment). I think it would make sense and adds value in general.

@nimishavijay
Copy link
Member

show the email in the attendee list (always or when a contact is added with several emails), so that the user can remove the unwanted emails

This sounds good to me as well.

There should be something to indicate that there are multiple emails associated with one contact, especially when the group has many contacts. So we could possibly:

  1. show the emails only for the contacts with multiple emails (and not for every contact)
  2. show all the emails and sort the contacts with multiple emails up top
  3. show all emails and add some visual indication to show that the contact has multiple emails, like combining the 2 list items

I would go with 2) because it's simple and doesn't require any scrolling to see that there are multiple email contacts
cc @jancborchardt

@tcitworld
Copy link
Member Author

For now I have added the suggestion from @ChristophWurst as it's the easy part. However I'm not sure it's needed if we show the emails in the attendee item subline as per 2. .

image

In any case we really need to remove the « invitation sent » label until the event is saved and the invitations are really sent, as adding the email next to it will even more increase confusion.

@miaulalala
Copy link
Contributor

I fundamentally disagree with hiding the email address in the three dot menu. I think it should be visible immediately without user interaction as it is relevant information and belongs to the same sort of information as a Display Name is.

@ekrahmer
Copy link

from the user's perspective it is very simple: use the preferred email address
EMAIL;PREF=1;TYPE=OTHER:john@nowhere.com
EMAIL;TYPE=HOME:john@nowhere.net
This (RFC6350) PREF parameter is part of the NC contact database and can be handled by CardDAV apps like Cardbook. Ask the contact app developers to make it accessible in the NC web interface.

(I'm waiting since long to be able to invite the Tenor voice section of our choit to extra rehersals including theit accept/decline replies.....)

@jancborchardt
Copy link
Member

Talked a bit about this with @nimishavijay, we were going through the comments here and concluded:

  • It would be annoying to receive mails to all your email addresses. Already now we have the situation that when receiving an invite you just accept it, and it would just be more annoying notifications.
  • It would also be strange to clutter up the attendee list with all the mails of one person. You want to invite people, not emails. If you want to invite a person with a specific mail, you can still check through the list and invite the person via that mail

What we can do is:

  • Using the "preferred" mail address as suggested by @ekrahmer is a good option
    • If that doesn’t exist, simply only pick the first one. In a server like e.g. a work Nextcloud, it is likely the first (or only) mail of a person which is their relevant one for a work event.
  • Showing the emails directly in the list as mentioned by @miaulalala is also a good point. We can show them in the subline like so: "Invitation sent · mail@example.com"

@small1
Copy link

small1 commented Apr 12, 2023

Any status on this one? :) I just got a question about this feature and went looking for a ticket for it :)

@miaulalala
Copy link
Contributor

@tcitworld are you happy to implement the changes Jan suggested? I can take over otherwise, excellent work btw.

@miaulalala miaulalala added this to the v4.5.0 milestone Jul 4, 2023
@miaulalala miaulalala removed their request for review July 4, 2023 09:53
@miaulalala miaulalala self-assigned this Jul 4, 2023
@miaulalala miaulalala added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 4, 2023
@miaulalala miaulalala removed this from the v4.5.0 milestone Aug 17, 2023
@VLGM
Copy link

VLGM commented Dec 21, 2023

Hi,

I'm a newbie but when this will be released ?
How can I use this, because I absolutely need this function form teams planning.

Regards

@Ekinoxies
Copy link

Hello all, great work ! Do you know when this feature will be implemented ? :D

@JMoVS
Copy link

JMoVS commented Jan 25, 2024

has there been any movement on this?

@Durkar
Copy link

Durkar commented Mar 20, 2024

It would be great, if someone will contiue the work. :)

@Upperholme
Copy link

The lack of any way to easily add multiple email addresses as invitees to an event is crippling. I've tried pasting in a comma separated list of addresses (doesn't work), pasting in from Excel or similar (doesn't work), adding contacts to an address book and/or group in the Contacts app and trying to name the book or group in the invitees field. Any or all of these approaches would allow me to use Nextcloud calendar. This particular thread is 18 months old. I've come across others that stretch back to 2015 or beyond.

tcitworld and others added 3 commits April 19, 2024 17:14
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@miaulalala miaulalala force-pushed the allow-to-select-contact-groups branch from 710866c to 392d969 Compare April 19, 2024 15:30
@miaulalala
Copy link
Contributor

Added the email as text next to the attendees:

image

I think I broke the lovely #5396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
Status: 📄 To do
Thomas things to do
  
In progress
Development

Successfully merging this pull request may close these issues.

Add contact groups as attendees for an event [$50]