Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n: Triple dot ellipsis #1658

Merged
merged 4 commits into from
Nov 20, 2019
Merged

l10n: Triple dot ellipsis #1658

merged 4 commits into from
Nov 20, 2019

Conversation

rakekniven
Copy link
Member

Reported at Transifex.

Signed-off-by: rakekniven mark.ziegler@rakekniven.de

Reported at Transifex.

Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke
Copy link
Member

@rakekniven I fixed some more :)

@tcitworld
Copy link
Member

Also make sure we have a non-breaking space before the ellipsis so that it doesn't go on another line in some cases (we shouldn't have those, but still).

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@tcitworld
Copy link
Member

eslint is not happy about the non-breaking spaces.

@georgehrke
Copy link
Member

I opened an issue in our eslint-config: nextcloud-libraries/eslint-config#9

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke merged commit b40ea81 into master Nov 20, 2019
@georgehrke georgehrke deleted the rakekniven-patch-1 branch November 20, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants