Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable22]: Add composer patch #890

Merged
merged 1 commit into from Nov 15, 2021
Merged

Conversation

CarlSchwan
Copy link
Member

This might be helpful later and unify the handling with master

Signed-off-by: Carl Schwan carl@carlschwan.eu

@nickvergessen
Copy link
Member

Conflicts with https://github.com/nextcloud/3rdparty/blob/stable22/patches.txt ? or well should we add them all to make sure they are applied correctly?

@CarlSchwan
Copy link
Member Author

Conflicts with https://github.com/nextcloud/3rdparty/blob/stable22/patches.txt ? or well should we add them all to make sure they are applied correctly?

Unfortunately, It seems this list of patches isn't getting applied for a while now :( And I'm not completely sure if we should try to apply them again or just remove that list and consider it as outdated.

@CarlSchwan
Copy link
Member Author

I took a look at the patches listed in the file. These are the one who didn't get merged:

@nickvergessen
Copy link
Member

@nickvergessen
Copy link
Member

Fix like escape for sqlite doctrine/dbal#3104

When this is still applied in our code base we should add the patch as well, so it is reapplied on every update.
Otherwise good to go

This might be helpful later and unify the handling with master

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan merged commit ca58d28 into stable22 Nov 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the work/composer-patch-stable22 branch November 15, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants