Repairing BASE64 encoded vCard version 3

[Webbeh]

Fix nextcloud/server#3366

Simple re-application of the same patch as upstream
sabre-io/vobject#441

[skjnldsv]

Hum, this would require also a repair step in nextcloud/server, right?

[Webbeh]

@evert on the upstream issue (sabre-io/vobject#415) commented that sabre/dav calls the validate function with the repair flag by default. There shouldn't be any more step needed in nextcloud, assuming that repair flag wasn't removed.

[Webbeh]

After "blindly" applying the patch to Nextcloud's Property.php, it seems to work flawlessy with my device, which seems to imply that the "repair" option is called by nextcloud by default as well -> nothing more to do than patch.

[MorrisJobke]

@rullzer @skjnldsv @ChristophWurst @georgehrke 🏓

[Webbeh]

I will try beta 16 and report back here.

[MorrisJobke]

@rullzer @skjnldsv @ChristophWurst @georgehrke 🏓

🏓

[georgehrke]

👍

[Webbeh]

Thanks!

[skjnldsv]

Drone is not enabled here @MorrisJobke ?

[MorrisJobke]

Drone is not enabled here @MorrisJobke ?

Correct, because 3rdparty without an update to the server code is quite meaningless. Thus a PR to server is needed to check against our code base.

[skjnldsv]

Ideally we could get icewind1991/SearchDAV#9
And then we'd be able to upgrade sbre/dav to 4.2.0+ where this fix is

https://github.com/sabre-io/vobject/releases/tag/4.2.0

[icewind1991]

Ideally we could get icewind1991/SearchDAV#9

done

[skjnldsv]

@icewind1991 you used 4.0.x, we would need 4.2.x 🙈 ❤️

[Webbeh]

@skjnldsv #398 contains the fix, so this will be able to be closed.

[icewind1991]

@icewind1991 you used 4.0.x, we would need 4.2.x see_no_evil heart

sabre/dav only goes up to 4.0, it's sabre/vobject is 4.2

[skjnldsv]

Ah sorry!! All good then!