Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed VCard V3 with BASE64 encoding being rejected #124

Closed
wants to merge 1 commit into from
Closed

Fixed VCard V3 with BASE64 encoding being rejected #124

wants to merge 1 commit into from

Conversation

Webbeh
Copy link

@Webbeh Webbeh commented Jun 17, 2018

Fixes issue nextcloud/server#3366 where some early implementations of VCard 3.0 use the BASE64 (instead of B) encoding.

@MorrisJobke
Copy link
Member

@Webbeh Thanks for your contribution. As this is a 3rdparty library it would be best to hand in the change as well to the upstream project. Did you open a pull request there as well? If not it would make sense to get an opinion of the maintainers as well: https://github.com/sabre-io/vobject

@Webbeh
Copy link
Author

Webbeh commented Jun 18, 2018

Ah, thanks, I didn't find the vobject folder in there, I assumed NC rewrote it using sabre's API or something.

Will do.

@msberends
Copy link

Care to share where the new issue is? Can't find it in the project.

@stadeli
Copy link

stadeli commented Dec 21, 2018

Hi, dumb question: How can I install this fix? I'm getting this same error when trying to sync my contacts from Nextcloud to Outlook, using CalDav Synchronizer 3.3.0.0

Validation error in vCard: ENCODING=B,B is not valid for this document type

If you could explain this solution for dummies, we would appreciate it!!

Thanks
Daniel

@Webbeh Webbeh closed this Dec 25, 2018
@Webbeh
Copy link
Author

Webbeh commented Dec 25, 2018

sabre-io/vobject#441
Fixing upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants