Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated dependabot approve and merge #9

Merged
merged 1 commit into from Jun 29, 2021
Merged

Conversation

skjnldsv
Copy link
Member

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv self-assigned this Jun 29, 2021
@skjnldsv skjnldsv added 3. to review Waiting for reviews enhancement New feature or request labels Jun 29, 2021
@PVince81
Copy link
Member

I'm not a fan, especially after that time where an automatic merge of a patch update of babel broke Talk with IE, ref: nextcloud/spreed#4818. Now the benefit of automerge might still outweight the potential low risk of such breakage ?

@skjnldsv
Copy link
Member Author

Well, for one that fails successfully, we have 100 that works and are safe to be auto-merged.
I think so far it helped us reduce a lot of our global dependabot process.
So far this has been enabled in almost all repos and for the last 18 months only a few issues were caught and reverted. 🤔

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 29, 2021

in any case @PVince81 talk is not using this, so you're on the safe side. This one will only update repos that already uses it :)

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 fine by me

we should anyway smoke test with browsers before releasing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants