Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] chore(config): migrate to new eslint config #441

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Jan 12, 2023

I'm kinda stuck. Anyone feel free to help

Currently struggling with the plugins and the extends.
Seems we could help ourselves from https://eslint.org/blog/2022/08/new-config-system-part-2/#backwards-compatibility-utility

  • Migrate config
  • Split each config into separate files for readability and import-spread them in the main eslint.config.js file?

Refs:

@skjnldsv skjnldsv added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jan 12, 2023
@susnux
Copy link
Contributor

susnux commented Jan 30, 2023

@skjnldsv I pushed some commits fixing the config, it is now possible to use it for linting.
I added comments why each config had to be included using the compat wrapper, I did not test TS just the first sub-config.

I think the problem was that eslint must be setup to support esm, but it was set to ES6 (min. 2017 is required, for some options even ES2020).

@skjnldsv
Copy link
Contributor Author

lint is failing :)

@skjnldsv
Copy link
Contributor Author

This would be a breaking change @susnux @raimund-schluessler ?

@susnux susnux force-pushed the feat/nex-eslint-syntax branch 2 times, most recently from 1124cc2 to 2314760 Compare January 31, 2023 14:43
@susnux
Copy link
Contributor

susnux commented Jan 31, 2023

Hm, it feels like yes, but as we already require an eslint version that supports flat configs this should not break any packages that works with the current release.

@susnux
Copy link
Contributor

susnux commented Apr 15, 2024

New ESLint with flat config was released 🎉
Time for a new major version here :)

Just waiting for this blocker: typescript-eslint/typescript-eslint#8211

skjnldsv and others added 5 commits April 15, 2024 13:39
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
… `module` or `exports`

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
… using es2020+

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
…lled

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants