feat(sveltekit): webauthn provider support #9924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Fix typos in supabase adapter documentation
ThangHuuVu
reviewed
May 11, 2024
ThangHuuVu
approved these changes
May 11, 2024
sillvva
reviewed
May 17, 2024
| * @returns WebAuthn response or error | ||
| */ | ||
| async function webAuthnOptions(providerId: string, options?: SignInOptions) { | ||
| const baseUrl = `${base}/auth/` |
There was a problem hiding this comment.
There's a mistake here with the ending /. Below an additional / is added after baseUrl. Results in a 404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
next-authclientsignInimport which includes thewebauthnimport@simplewebauth/server@9.0.2which should fix theimport node:cryptoissue on edge runtimes/apps/dev/sveltekit/tmp-unstorage. This makes the saving of your webauthn authenticators persist across restarts of your dev server, like HMR, etc. The unstorage tmp dir is a part of the.gitignore👍🧢 Checklist
🎫 Affected issues
📌 Resources