Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring duende-identitysever6 docs into docs v4 #5999

Closed

Conversation

dbfr3qs
Copy link

@dbfr3qs dbfr3qs commented Dec 9, 2022

NOTE:

  • It's a good idea to open an issue first to discuss potential changes.
  • Please make sure that you are NOT opening a PR to fix a potential security vulnerability. Instead, please follow the Security guidelines to disclose the issue to us confidentially.

☕️ Reasoning

It looks like the Duende IdentityServer6 documentation was added to v3 of the docs in this PR but doesn't look to have been included in v4 of the docs. This simply adds the file back into the main doc directory so it's included in the build.

image

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: INSERT_ISSUE_LINK_HERE

📌 Resources

@vercel
Copy link

vercel bot commented Dec 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 15, 2022 at 8:04PM (UTC)
next-auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 15, 2022 at 8:04PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
next-auth ⬜️ Ignored (Inspect) Dec 15, 2022 at 8:04PM (UTC)

@vercel vercel bot temporarily deployed to Preview December 9, 2022 01:29 Inactive
@vercel vercel bot temporarily deployed to Preview December 9, 2022 02:08 Inactive
@ndom91
Copy link
Member

ndom91 commented Dec 12, 2022

Nice catch! Can you add it also to the versioned_docs/version-beta/oauth-providers/ directory? We plan on merging those beta docs as main docs soon.

Thanks 🙏

@dbfr3qs dbfr3qs force-pushed the patch-doc-duende-identityserver branch from e444703 to b64ff92 Compare December 12, 2022 19:24
@vercel vercel bot temporarily deployed to Preview December 12, 2022 19:26 Inactive
@vercel vercel bot temporarily deployed to Preview December 12, 2022 19:52 Inactive
@dbfr3qs
Copy link
Author

dbfr3qs commented Dec 13, 2022

Nice catch! Can you add it also to the versioned_docs/version-beta/oauth-providers/ directory? We plan on merging those beta docs as main docs soon.

Thanks 🙏

No worries - that is done 👍

@vercel
Copy link

vercel bot commented Dec 14, 2022

@ndom91 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@ndom91
Copy link
Member

ndom91 commented Dec 14, 2022

Alright so, I'm sorry to ask for antoher switcheroo haha, but the previous version-beta docs have been moved to the main docs now, meaning there are no more versioned_docs/** directories/files anymore.

Only the change to the main /docs/docs/ page is required now. Could you update it one more time and we'll get it merged? 🙏

@dbfr3qs
Copy link
Author

dbfr3qs commented Dec 15, 2022

Alright so, I'm sorry to ask for antoher switcheroo haha, but the previous version-beta docs have been moved to the main docs now, meaning there are no more versioned_docs/** directories/files anymore.

Only the change to the main /docs/docs/ page is required now. Could you update it one more time and we'll get it merged? 🙏

No worries - all done 👍

@dbfr3qs
Copy link
Author

dbfr3qs commented Mar 7, 2023

@ndom91 is this still required? Just wondering if I should resync with the base branch...

@balazsorban44 balazsorban44 added documentation Relates to documentation providers legacy Refers to `next-auth` v4. Minimal maintenance. labels Mar 29, 2023
@ThangHuuVu
Copy link
Member

hi @dbfr3qs , this shouldn't be necessary anymore, checkout our latest doc at https://authjs.dev/reference/core/providers_duende-identity-server6

Thanks for the PR though! 🙏

@ThangHuuVu ThangHuuVu closed this Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to documentation legacy Refers to `next-auth` v4. Minimal maintenance. providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants