Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Next.js 13.0.1 #5710

Merged
merged 4 commits into from Nov 4, 2022
Merged

feat: support Next.js 13.0.1 #5710

merged 4 commits into from Nov 4, 2022

Conversation

HaNdTriX
Copy link
Contributor

@HaNdTriX HaNdTriX commented Nov 2, 2022 •
edited by balazsorban44

☕️ Reasoning

  1. Next.js 13.0.1 introduces a new RequestCookie API. This breaks getToken. 04ea576
  2. Next.js 13.0.1 doesn't invoke middleware with an instance of NextRequest. c4087fc

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes: #5649, Fixes #5701, Fixes #5704, Fixes #5705

@vercel
Copy link

vercel bot commented Nov 2, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
next-auth ⬜️ Ignored (Inspect) Nov 2, 2022 at 10:33AM (UTC)

@github-actions github-actions bot added the core Refers to `@auth/core` label Nov 2, 2022
@HaNdTriX HaNdTriX changed the title RFC: Support Next 13.0.1 feat: support Next.js 13.0.1 Nov 2, 2022
vedantmgoyal9
vedantmgoyal9 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@vedantmgoyal9 vedantmgoyal9 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eagerly waiting for this! Please merge and release soon 🙂

MalteBoehm
MalteBoehm approved these changes Nov 3, 2022
View reviewed changes
Copy link

@MalteBoehm MalteBoehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m 🚀

balazsorban44
balazsorban44 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made these changes locally myself, but happy to merge your PR instead! Thanks for the great work!

@balazsorban44 balazsorban44 merged this pull request into nextauthjs:main Nov 4, 2022
balazsorban44 pushed a commit that referenced this pull request Nov 4, 2022
@HaNdTriX @balazsorban44
fix: support Next.js 13 (#5710)
060953d 
* Migrate dev app to Next.js Version 13

* Update core types

* Fix middleware

#5649

* Use new ResponseCookie API

vercel/next.js#41526
@HaNdTriX HaNdTriX deleted the next-13.0.1 branch November 4, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@raulmarindev raulmarindev raulmarindev approved these changes

@MalteBoehm MalteBoehm MalteBoehm approved these changes

@vedantmgoyal9 vedantmgoyal9 vedantmgoyal9 approved these changes

@ThangHuuVu ThangHuuVu Awaiting requested review from ThangHuuVu ThangHuuVu is a code owner

@ubbe-xyz ubbe-xyz Awaiting requested review from ubbe-xyz ubbe-xyz is a code owner

@ndom91 ndom91 Awaiting requested review from ndom91 ndom91 is a code owner

Assignees
No one assigned
Labels
core Refers to `@auth/core`
Projects
None yet
Milestone
No milestone
5 participants
@HaNdTriX @balazsorban44 @raulmarindev @MalteBoehm @vedantmgoyal9