Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show experimental api warning only in dev and only once #4816

Merged
merged 6 commits into from Jul 2, 2022
Merged

fix: show experimental api warning only in dev and only once #4816

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dff64a5
feat: show experimental api warning only in dev and only once
ndom91 Jul 2, 2022
ec2ac1d
fix: move tracking var outside of function call
ndom91 Jul 2, 2022
e81c691
fix: env check
ndom91 Jul 2, 2022
2a98639
Update packages/next-auth/src/next/index.ts
ndom91 Jul 2, 2022
d6d4aaf
Update packages/next-auth/src/next/index.ts
ndom91 Jul 2, 2022
1907c66
feat: add unstable_getServerSession console.warn test
ndom91 Jul 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 16 additions & 8 deletions packages/next-auth/src/next/index.ts
View file
Open in desktop
Expand Up @@ -82,21 +82,29 @@ function NextAuth(
}

export default NextAuth
let shown = false

export async function unstable_getServerSession(
ndom91 marked this conversation as resolved.
Show resolved Hide resolved
...args:
| [GetServerSidePropsContext['req'], GetServerSidePropsContext['res'], NextAuthOptions]
| [
GetServerSidePropsContext["req"],
GetServerSidePropsContext["res"],
NextAuthOptions
]
| [NextApiRequest, NextApiResponse, NextAuthOptions]
): Promise<Session | null> {
console.warn(
"[next-auth][warn][EXPERIMENTAL_API]",
"\n`unstable_getServerSession` is experimental and may be removed or changed in the future, as the name suggested.",
`\nhttps://next-auth.js.org/configuration/nextjs#unstable_getServerSession}`,
`\nhttps://next-auth.js.org/warnings#EXPERIMENTAL_API`
if (!shown && process.env.NODE_ENV !== "production") {
console.warn(
"[next-auth][warn][EXPERIMENTAL_API]",
"\n`unstable_getServerSession` is experimental and may be removed or changed in the future, as the name suggested.",
`\nhttps://next-auth.js.org/configuration/nextjs#unstable_getServerSession}`,
`\nhttps://next-auth.js.org/warnings#EXPERIMENTAL_API`
)
shown = true
ndom91 marked this conversation as resolved.
Show resolved Hide resolved
}

const [req, res, options] = args

const [req, res, options] = args;

options.secret = options.secret ?? process.env.NEXTAUTH_SECRET

const session = await NextAuthHandler<Session | {}>({
Expand Down