Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(signin.tsx): set type of built-in email sign-in input to "email" and add "required" attribute for browser validation #4352

Merged
merged 8 commits into from Apr 15, 2022
Merged

fix(signin.tsx): set type of built-in email sign-in input to "email" and add "required" attribute for browser validation #4352

merged 8 commits into from Apr 15, 2022

Commits on Apr 7, 2022

  1. fix(core\pages\signin.tsx): set type of built-in email sign-in input … 

    …to email for browse validation

Currently, the built-in sign-in page has the wrong type (text) for the input for emails when using
the magic link provider. Because of this a user can enter whatever they want in that input. By
switching the type to be email we can make use of the browser provided validation and users will be
forced to use properly formed emails addresses in order to sign-in.
    @raulmarindev
    raulmarindev committed Apr 7, 2022
    Copy the full SHA
    f204fb4 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2022

  1. Merge branch 'main' into main

    @ubbe-xyz
    ubbe-xyz committed Apr 9, 2022
    Copy the full SHA
    c4db45e View commit details
    Browse the repository at this point in the history

  2. fix(core\pages\signin.tsx): add required attribute to built-in sign-i… 

    …n email input

Currently, the built-in sign-in page doesn't have the required attribute for the input for emails
when using the magic link provider. Because of this a user is able to submit the form without
entering a value. By adding the "required" attribute we can make use of the browser provided
validation and users will be forced to provide a value in order to sign-in.
    @raulmarindev
    raulmarindev committed Apr 9, 2022
    Copy the full SHA
    ae65af7 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2022

  1. Merge branch 'main' into main

    @ubbe-xyz
    ubbe-xyz committed Apr 10, 2022
    Copy the full SHA
    10bf906 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Merge branch 'main' into main

    @raulmarindev
    raulmarindev committed Apr 13, 2022
    Copy the full SHA
    96766bc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into main

    @raulmarindev
    raulmarindev committed Apr 13, 2022
    Copy the full SHA
    52a8d5f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into main

    @ubbe-xyz
    ubbe-xyz committed Apr 13, 2022
    Copy the full SHA
    64559f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2022

  1. Merge branch 'main' into main

    @ubbe-xyz
    ubbe-xyz committed Apr 15, 2022
    Copy the full SHA
    37a6f04 View commit details
    Browse the repository at this point in the history