Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added idToken: true to Battlenet provider #4014

Closed
wants to merge 1 commit into from
Closed

Conversation

Stono
Copy link
Contributor

@Stono Stono commented Feb 19, 2022

Part fixes: #4013

Reasoning 💡

To help fix the battlenet provider

Checklist 🧢

  • [ ] Documentation
  • [ ] Tests
  • Ready to be merged

Affected issues 🎟

#4013

@vercel
Copy link

vercel bot commented Feb 19, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/6v2KTkxxB7MfPUrDvikYKFFULoPh
✅ Preview: Canceled

@github-actions github-actions bot added core Refers to `@auth/core` providers labels Feb 19, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a much easier solution, they support OIDC:

https://develop.battle.net/documentation/guides/using-oauth/oidc-endpoints

See for example https://github.com/nextauthjs/next-auth/blob/main/packages/next-auth/src/providers/auth0.ts on how to configure OIDC.

idToken: true won't be necessary either then, since #3514

These changes will most likely fix #4013 entirely 👍

@Stono
Copy link
Contributor Author

Stono commented Feb 19, 2022

Looks like there is a much easier solution, they support OIDC:

https://develop.battle.net/documentation/guides/using-oauth/oidc-endpoints

See for example https://github.com/nextauthjs/next-auth/blob/main/packages/next-auth/src/providers/auth0.ts on how to configure OIDC.

idToken: true won't be necessary either then, since #3514

These changes will most likely fix #4013 entirely 👍

Yip exactly the route i was going down! I will close this issue and PR another

@Stono Stono closed this Feb 19, 2022
@Stono
Copy link
Contributor Author

Stono commented Feb 19, 2022

@balazsorban44 opened a new PR over at #4015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BattleNet Provider doesn't work (few issues)
2 participants