fix: only warn when using Twitter + OAuth 2.0 #4003
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@theobr reported this to me, thank you. We should only show the warning if the user opts into Twitter + OAuth 2.0, as their implementation is still somewhat subject to change.
In a future release, we can swap this warning to encourage people to use OAuth 2.0, so after that we can finally drop support for OAuth 1.0 support together with a 5-year-old 130kb dependency, decreasing the install size by ~40%!
I would like to entertain the idea that once we get the green light from Twitter to advertise their OAuth 2 over OAuth 1, we just bump to v5 and only require the user to install the
oauth
dependency only if they use Twitter 1.The code is already pretty safe and would not block other users to decrease their bundle size.
Reasoning 💡
Checklist 🧢
Affected issues 🎟