Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade pnpm #10825

Merged
merged 2 commits into from May 11, 2024
Merged

chore: upgrade pnpm #10825

merged 2 commits into from May 11, 2024

Conversation

ThangHuuVu
Copy link
Member

☕️ Reasoning

Upgrade pnpm to v9, mainly for the lockfile
More info: https://github.com/pnpm/pnpm/releases/tag/v9.0.0

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented May 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 6:49am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 6:49am
proxy ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 6:49am

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@prisma/client@5.13.0 environment, filesystem, shell 0 8.93 MB prismabot
npm/@solid-auth/next@0.0.19 environment Transitive: network +4 1.34 MB orjdev
npm/@solidjs/meta@0.28.7 None 0 20.4 kB ryansolid
npm/@solidjs/router@0.6.0 None 0 87.6 kB ryansolid
npm/@sveltejs/adapter-auto@1.0.0-next.91 environment, filesystem, shell Transitive: eval +11 1.48 MB svelte-admin
npm/@sveltejs/adapter-auto@3.2.0 environment +1 84.2 kB svelte-admin
npm/@sveltejs/kit@2.4.3 environment, eval Transitive: filesystem, network, shell, unsafe +31 221 MB svelte-admin
npm/@sveltejs/kit@2.5.7 environment, eval Transitive: filesystem +15 1.47 MB svelte-admin
npm/@sveltejs/vite-plugin-svelte@3.1.0 Transitive: environment, filesystem, network, shell, unsafe +37 217 MB svelte-admin
npm/@types/node@18.19.31 None 0 1.97 MB types
npm/@types/react-dom@18.3.0 None 0 37.8 kB types
npm/@types/react@18.3.1 None 0 438 kB types
npm/clsx@2.1.1 None 0 8.55 kB lukeed
npm/next@14.2.0-canary.47 environment, filesystem, network, shell, unsafe +13 1.19 GB vercel-release-bot
npm/next@14.2.3 environment, filesystem, network, shell, unsafe +10 1.19 GB vercel-release-bot
npm/prisma@5.13.0 environment Transitive: eval, filesystem, shell +5 14 MB prismabot
npm/react-dom@18.3.1 environment +1 4.61 MB react-bot
npm/react@18.3.1 environment 0 318 kB react-bot
npm/sqlite3@5.1.7 Transitive: environment, filesystem, network, shell +88 8.34 MB daniellockyer
npm/svelte-check@2.10.2 Transitive: environment, filesystem, unsafe +8 21.5 MB svelte-language-tools-deploy
npm/svelte-check@3.6.9 Transitive: environment, eval, filesystem, unsafe +31 10.5 MB svelte-language-tools-deploy
npm/svelte@4.2.15 Transitive: unsafe +19 6.71 MB svelte-admin
npm/typescript@5.4.5 None 0 32.4 MB typescript-bot
npm/unstorage@1.10.2 Transitive: environment, filesystem, network, shell +43 12 MB pi0
npm/vite@4.5.3 environment, eval, filesystem, network, shell, unsafe +26 219 MB vitebot
npm/vite@5.2.10 environment, eval, filesystem, network, shell, unsafe +3 6.01 MB vitebot

🚮 Removed packages: npm/@actions/core@1.10.1, npm/@ariakit/react@0.4.5, npm/@auth/prisma-adapter@2.0.0, npm/@auth/unstorage-adapter@2.0.0, npm/@aws-sdk/client-dynamodb@3.499.0, npm/@aws-sdk/lib-dynamodb@3.499.0, npm/@azure/data-tables@13.2.2

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/svelte-preprocess@4.10.7
  • Install script: postinstall
  • Source: echo "[svelte-preprocess] Don't forget to install the preprocessors packages that will be used: node-sass/sass, stylus, less, postcss & postcss-load-config, coffeescript, pug, etc..."
Install scripts npm/svelte-preprocess@5.1.3
  • Install script: postinstall
  • Source: echo "[svelte-preprocess] Don't forget to install the preprocessors packages that will be used: sass, stylus, less, postcss & postcss-load-config, coffeescript, pug, etc..."
Install scripts npm/@sveltejs/kit@2.4.3
  • Install script: postinstall
  • Source: node postinstall.js
Install scripts npm/@sveltejs/kit@1.30.4
  • Install script: postinstall
  • Source: node postinstall.js
Install scripts npm/@sveltejs/kit@2.5.7
  • Install script: postinstall
  • Source: node postinstall.js
Install scripts npm/@prisma/engines@5.13.0
  • Install script: postinstall
  • Source: node scripts/postinstall.js
Install scripts npm/@prisma/client@5.13.0
  • Install script: postinstall
  • Source: node scripts/postinstall.js
Install scripts npm/prisma@5.13.0
  • Install script: preinstall
  • Source: node scripts/preinstall-entry.js

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/svelte-preprocess@4.10.7
  • @SocketSecurity ignore npm/svelte-preprocess@5.1.3
  • @SocketSecurity ignore npm/@sveltejs/kit@2.4.3
  • @SocketSecurity ignore npm/@sveltejs/kit@1.30.4
  • @SocketSecurity ignore npm/@sveltejs/kit@2.5.7
  • @SocketSecurity ignore npm/@prisma/engines@5.13.0
  • @SocketSecurity ignore npm/@prisma/client@5.13.0
  • @SocketSecurity ignore npm/prisma@5.13.0

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.81%. Comparing base (3833baa) to head (a8b8818).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10825      +/-   ##
==========================================
+ Coverage   37.51%   37.81%   +0.30%     
==========================================
  Files         173      173              
  Lines       26983    26983              
  Branches     1176     1182       +6     
==========================================
+ Hits        10122    10204      +82     
+ Misses      16861    16779      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91
Copy link
Member

ndom91 commented May 6, 2024

Want to do the example apps as well? They have their own pnpm-lock.yaml.

Can be updated with pnpm i --ignore-workspace in their respective directories.

@ThangHuuVu
Copy link
Member Author

@ndom91 done with all the example, merging this!

@ThangHuuVu ThangHuuVu merged commit 117110f into main May 11, 2024
14 of 15 checks passed
@ThangHuuVu ThangHuuVu deleted the chore/upgrade-pmpm branch May 11, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants