Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sveltekit): update sveltekit eslint tooling #10748

Merged
merged 11 commits into from May 1, 2024

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented Apr 28, 2024

☕️ Reasoning

  • Update svelte eslint tooling from eslint-plugin-svelte3 to eslint-plugin-svelte (Source)
  • Added dist output folder to clean npm script in framework-sveltekit
  • Cleaned up a few small things like rm ignoring directories that no longer exist and removing unnecessary prettier overrides

I'd love someone with VSCode to test this as well though, looks good to me in nvim and build output is the same too

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 9:49am
proxy ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 9:49am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 9:49am

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.12%. Comparing base (e6f90b2) to head (d260cba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10748   +/-   ##
=======================================
  Coverage   41.12%   41.12%           
=======================================
  Files         173      173           
  Lines       28472    28472           
  Branches     1179     1179           
=======================================
  Hits        11710    11710           
  Misses      16762    16762           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ThangHuuVu ThangHuuVu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove next-auth/packages/frameworks-sveltekit/.eslintrc.cjs, I think its not used right

packages/frameworks-sveltekit/package.json Outdated Show resolved Hide resolved
Co-authored-by: Thang Vu <hi@thvu.dev>
Copy link

socket-security bot commented Apr 30, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@ndom91
Copy link
Member Author

ndom91 commented Apr 30, 2024

Should we also remove next-auth/packages/frameworks-sveltekit/.eslintrc.cjs, I think its not used right

Yeah I think you're right. I've removed them 👍

@ThangHuuVu
Copy link
Member

@ndom91 there is still one issue in the build, shall we fix it here too?

@github-actions github-actions bot added providers core Refers to `@auth/core` labels Apr 30, 2024
@ndom91
Copy link
Member Author

ndom91 commented Apr 30, 2024

@ThangHuuVu yeah good eye - just ran prettier on it and pushed. Lets see

@github-actions github-actions bot removed providers core Refers to `@auth/core` labels May 1, 2024
@ndom91 ndom91 changed the title fix(tooling): update sveltekit eslint tooling chore(sveltekit): update sveltekit eslint tooling May 1, 2024
@ndom91 ndom91 merged commit d923192 into main May 1, 2024
14 of 15 checks passed
@ndom91 ndom91 deleted the ndom91/update-svelte-config branch May 1, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants