Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(provider): SailPoint Identity Secure Cloud (ISC) #10723

Merged
merged 27 commits into from May 10, 2024

Conversation

mike818148
Copy link
Contributor

☕️ Reasoning

A new oauth provider for SailPoint Identity Secure Cloud (ISC). Developers then can utilize SailPoint Identity Secure Cloud (ISC) to authenticate the custom authentication based on OAuth2 standard.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 1:18pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 1:18pm

@mike818148
Copy link
Contributor Author

mike818148 commented Apr 29, 2024

Hello,

please let me know should I also prepare a test environment for you to conduct some testing, understand it will be hard to allocate a SailPoint IdentityNow tenant for you to test directly. By providing this provider, I believe it will bring some value to the SailPoint Developer community, especially for React developers.

on my side, I already finished some testings on my side.

Copy link

vercel bot commented Apr 29, 2024

@mike818148 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@mike818148 mike818148 changed the title New Provider: SailPoint Identity Secure Cloud (ISC) feat(Provider): SailPoint Identity Secure Cloud (ISC) Apr 30, 2024
@mike818148 mike818148 changed the title feat(Provider): SailPoint Identity Secure Cloud (ISC) feat(provider): SailPoint Identity Secure Cloud (ISC) Apr 30, 2024
@ndom91
Copy link
Member

ndom91 commented Apr 30, 2024

@mike818148 thanks for the interest in the project.

So if I understand correctly, SailPoint is an enterprise identity/security platform? So a random developer like me wouldn't be able to get OAuth Client credentials probably, right?

@ndom91
Copy link
Member

ndom91 commented Apr 30, 2024

In the mean time, you could also add a docs page at /docs/pages/getting-started/providers/sailpoint.mdx. You can copy the structure of any of the other providers, like Netlify.mdx for example, and just fill in the info yuo've got in the JSDoc of your provider already 🙏

@mike818148
Copy link
Contributor Author

mike818148 commented Apr 30, 2024

@mike818148 thanks for the interest in the project.

So if I understand correctly, SailPoint is an enterprise identity/security platform? So a random developer like me wouldn't be able to get OAuth Client credentials probably, right?

Hello @ndom91,

this is correct, SailPoint Identity Secure Cloud(ISC) is an enterprise SaaS platform for identity/security solution. At the moment, random developer may not get an OAuth Client credentials (from a certain tenant) as easy as other OAuth provider, however, I believe this statement is also changing. As per my understanding, SailPoint already have a open developer community which welcome public to join, and it also has a opensource project , and as an active developer community member, there is a way to requst a ISC tenant for demo/developing.

@ndom91
Copy link
Member

ndom91 commented Apr 30, 2024

Hello @ndom91,

this is correct, SailPoint Identity Secure Cloud(ISC) is an enterprise SaaS platform for identity/security solution. At the moment, random developer may not get an OAuth Client credentials (from a certain tenant) as easy as other OAuth provider, however, I believe this statement is also changing. As per my understanding, SailPoint already have a open developer community which welcome public to join, and it also has a opensource project , and as an active developer community member, there is a way to requst a ISC tenant for demo/developing.

Oh okay I see. If you could request a demo tenant for this so we can continuously test it etc. that'd be amazing 🙏

If it goes through, you can DM it to me on our discord for example (@ndom91)

@mike818148
Copy link
Contributor Author

Hello @ndom91,
this is correct, SailPoint Identity Secure Cloud(ISC) is an enterprise SaaS platform for identity/security solution. At the moment, random developer may not get an OAuth Client credentials (from a certain tenant) as easy as other OAuth provider, however, I believe this statement is also changing. As per my understanding, SailPoint already have a open developer community which welcome public to join, and it also has a opensource project , and as an active developer community member, there is a way to requst a ISC tenant for demo/developing.

Oh okay I see. If you could request a demo tenant for this so we can continuously test it etc. that'd be amazing 🙏

If it goes through, you can DM it to me on our discord for example (@ndom91)

thanks a lot. I already have a tenant, would it be okai, we use this tenant for testing, if yes, I just need your email to register on the tenant. This tenant only contains mock-up data. I will then also share the guide regarding OAuth client setup with you (just to show you where to find it)

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.78%. Comparing base (86e354d) to head (16e0237).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10723      +/-   ##
==========================================
+ Coverage   37.48%   37.78%   +0.30%     
==========================================
  Files         173      173              
  Lines       27026    27026              
  Branches     1174     1180       +6     
==========================================
+ Hits        10131    10213      +82     
+ Misses      16895    16813      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91 ndom91 changed the title feat(provider): SailPoint Identity Secure Cloud (ISC) chore(provider): SailPoint Identity Secure Cloud (ISC) May 10, 2024
@ndom91 ndom91 merged commit de586f6 into nextauthjs:main May 10, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants