Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework): add nuxt framework client #10684

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

peterbud
Copy link

@peterbud peterbud commented Apr 22, 2024

☕️ Reasoning

This PR is aiming to add support for Nuxt framework to @AuthJS

🧢 Checklist

  • Add SetEnvDefaults to be consistent with other frameworks
  • Discuss CSRF vs Origin checking approach
  • Optional: Add NuxtDevTools support
  • Documentation: TBD
  • Tests: TBD
  • Ready to be merged

🎫 Affected issues

N/A

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) Apr 25, 2024 0:04am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 0:04am

Copy link

socket-security bot commented Apr 22, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/zod@3.23.0 None 0 674 kB colinmcd94

View full report↗︎

@ndom91 ndom91 changed the title Adding Nuxt Framework feat(framework): add nuxt framework client Apr 22, 2024
@ndom91
Copy link
Member

ndom91 commented Apr 22, 2024

Followup Todos for us:

  • Add example repo (nextauthjs/nuxt-example-app)
  • Ensure Balazs github token can write to that (for sync)
  • Double check example code sync to that new repo
  • Add nuxt example app Vercel project (with shared env vars)
  • Add nuxt.authjs.dev subdomain

package.json Outdated
@@ -56,7 +57,8 @@
"typescript": "5.3.3",
"utils": "workspace:*",
"vite": "^5.0.13",
"vitest": "1.2.2"
"vitest": "1.2.2",
"vue-eslint-parser": "^9.4.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do eslint-plugin-vue and vue-eslint-parser need to be int he root package.json? Ideally these would be in the framework-nuxt/package.json instead

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, good point. I have moved them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second note: we would need this also in the apps/dev/nuxt project as well, right?

@orenmizr
Copy link

orenmizr commented May 7, 2024

is it possible to build it and use it as alpha until the production version released ? @peterbud

@peterbud
Copy link
Author

is it possible to build it and use it as alpha until the production version released ? @peterbud

I think we are pretty early in the process of creating this framework, I'd love to have a proper review from the AuthJS core members before suggesting to use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants