New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): update WorkOS docs #10616
Conversation
The `domain` used in the authorization param used in the example is deprecated and no longer supported. If it is still used WorkOS returns the error code `domain_connection_selector_not_allowed` with the description: > 'The `domain` connection selector is deprecated and may no longer be used. Use the `connection` or `organization` connection selectors instead.' See reference: https://workos.com/docs/reference/sso/get-authorization-url/error-codes#:~:text=domain_connection_selector_not_allowed
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The docs on the main branch (docs/pages/getting-started/providers/workos.mdx) probably need to be updated too but I do not know what your process is for this: |
@MoritzKn the |
@MoritzKn also why did you remove the rest of the example code? |
@ndom91 Regarding your second comment: The whole point of the example code is to create a login page that splits the domain name from the email address, and then use that "domain" so that WorkOS can tell which connection you want to use. If you simply specify the connection using the Further, while working, the example was a little bit contrived. It's a bit strange to prompt your users to enter an email address and then only use the domain part of that email. It was simply necessary to work around the shortcoming in the WorkOS API. Just specifying the organization seems like the easiest to me. Regarding your first comment: In my opinion, the entire "notes" section in the v5 docs is confusing and should be omitted. But maybe this is because in my use case I'm using WorkOS with just one backend providers, simply as a SAMl <> OAuth bridge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay yeah that makes a lot of sense. I've removed that part from the current (v5) docs as well since we support the connection
param directly when using the provider there.
☕️ Reasoning
The
domain
used in the authorization param used in the example is deprecated and no longer supported. If it is still used, WorkOS returns the error codedomain_connection_selector_not_allowed
with the description:See reference: https://workos.com/docs/reference/sso/get-authorization-url/error-codes#:~:text=domain_connection_selector_not_allowed
🧢 Checklist
🎫 Affected issues
Couldn't find any open WorkOS related issues.